Remove ListUrlsActivity

chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
index f856fcb44101c9336a617667aeb76042e3045911..d713a0198fa53aef15293862e723d2a1e11c6891 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
@@ -26,6 +26,11 @@ import javax.annotation.concurrent.ThreadSafe;
  */
 @ThreadSafe
 public class PhysicalWebUma {
+    public static final int NOTIFICATION_REFERER = 1;

[nyquist, 2017/01/31 21:44:33]

IS this and OPTIN_REFERER still in use?

[cco3, 2017/01/31 21:53:18]

No, they aren't in use.  What is the right course of action here?  We should
keep the value assigned to the other referers the same, correct?  Do we need to
mark anything in histograms as deprecated?

[nyquist, 2017/01/31 22:17:48]

There's a way for marking histograms obsolete. I don't know about specific
values though. I'd check with the team working on that.

If you want, it's OK with me for you to submit this and do that as a followup
though. Maybe just add a comment about it in this CL, and make them private?

+    public static final int OPTIN_REFERER = 2;
+    public static final int PREFERENCE_REFERER = 3;
+    public static final int DIAGNOSTICS_REFERER = 4;
+
     private static final String TAG = "PhysicalWeb";
     private static final String HAS_DEFERRED_METRICS_KEY = "PhysicalWeb.HasDeferredMetrics";
     private static final String OPT_IN_DECLINE_BUTTON_PRESS_COUNT =
@@ -55,6 +60,7 @@ public class PhysicalWebUma {
     private static final String PREFERENCE = "Preference";
     private static final int BOOLEAN_BOUNDARY = 2;
     private static final int TRISTATE_BOUNDARY = 3;
+    private static final int REFERER_BOUNDARY = 5;
 
     /**
      * Records a URL selection.
@@ -163,12 +169,12 @@ public class PhysicalWebUma {
      *     histograms.xml.
      */
     public static void onActivityReferral(int referer) {
-        handleEnum(ACTIVITY_REFERRALS, referer, ListUrlsActivity.REFERER_BOUNDARY);
+        handleEnum(ACTIVITY_REFERRALS, referer, REFERER_BOUNDARY);
         switch (referer) {
-            case ListUrlsActivity.PREFERENCE_REFERER:
+            case PREFERENCE_REFERER:
                 recordPhysicalWebState(LAUNCH_FROM_PREFERENCES);
                 break;
-            case ListUrlsActivity.DIAGNOSTICS_REFERER:
+            case DIAGNOSTICS_REFERER:
                 recordPhysicalWebState(LAUNCH_FROM_DIAGNOSTICS);
                 break;
             default:
@@ -291,7 +297,7 @@ public class PhysicalWebUma {
             uploadTimes(PWS_REFRESH_RESOLVE_TIMES, TimeUnit.MILLISECONDS);
             uploadCounts(TOTAL_URLS_INITIAL_COUNTS);
             uploadCounts(TOTAL_URLS_REFRESH_COUNTS);
-            uploadEnums(ACTIVITY_REFERRALS, ListUrlsActivity.REFERER_BOUNDARY);
+            uploadEnums(ACTIVITY_REFERRALS, REFERER_BOUNDARY);
             uploadEnums(createStateString(LOCATION_SERVICES, LAUNCH_FROM_DIAGNOSTICS),
                     BOOLEAN_BOUNDARY);
             uploadEnums(createStateString(LOCATION_PERMISSION, LAUNCH_FROM_DIAGNOSTICS),