Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2651503007: dart2js-kernel: Pass non-type arguments to constructor body (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: Pass non-type arguments to constructor body R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7b70c720fb1aec9666f40af45f6e042b24cc9fee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +27 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
passing types in a separate CL.
3 years, 11 months ago (2017-01-24 23:24:05 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-24 23:57:37 UTC) #3
sra1
3 years, 11 months ago (2017-01-25 00:32:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b70c720fb1aec9666f40af45f6e042b24cc9fee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698