MD Settings: Eliminate use of ES6 for Chrome OS

chrome/browser/resources/settings/internet_page/network_summary.js

Index: chrome/browser/resources/settings/internet_page/network_summary.js
diff --git a/chrome/browser/resources/settings/internet_page/network_summary.js b/chrome/browser/resources/settings/internet_page/network_summary.js
index 40350487918671c70b71abdb1676bd17759b6a48..8cf8cf1a48fcff238490d5ff6f59782e8b0dc426 100644
--- a/chrome/browser/resources/settings/internet_page/network_summary.js
+++ b/chrome/browser/resources/settings/internet_page/network_summary.js
@@ -268,7 +268,7 @@ Polymer({
       return;
     }
     // Find the active state for the type and update it.
-    for (let i = 0; i < this.activeNetworkStates_.length; ++i) {
+    for (var i = 0; i < this.activeNetworkStates_.length; ++i) {
       if (this.activeNetworkStates_[i].type == state.type) {
         this.activeNetworkStates_[i] = state;
         return;
@@ -343,8 +343,10 @@ Polymer({
     var newDeviceStates;
     if (opt_deviceStates) {
       newDeviceStates = /** @type {!DeviceStateObject} */ ({});
-      for (let state of opt_deviceStates)
+      for (var s = 0; s < opt_deviceStates.length; ++s) {
+        var state = opt_deviceStates[s];
         newDeviceStates[state.Type] = state;

[dpapad, 2017/01/23 19:12:54]

Nit: No need for temporary |state| variable, since it is only used once.
newDeviceStates[state.Type] = opt_deviceStates[s];

[stevenjb, 2017/01/24 02:02:04]

Twice. state.Type and state.

+      }
     } else {
       newDeviceStates = this.deviceStates_;
     }
@@ -363,16 +365,16 @@ Polymer({
     };
 
     var firstConnectedNetwork = null;
-    networkStates.forEach(function(state) {
-      let type = state.Type;
+    networkStates.forEach(function(networkState) {
+      var type = networkState.Type;
       if (!activeNetworkStatesByType.has(type)) {
-        activeNetworkStatesByType.set(type, state);
-        if (!firstConnectedNetwork && state.Type != CrOnc.Type.VPN &&
-            state.ConnectionState == CrOnc.ConnectionState.CONNECTED) {
-          firstConnectedNetwork = state;
+        activeNetworkStatesByType.set(type, networkState);
+        if (!firstConnectedNetwork && networkState.Type != CrOnc.Type.VPN &&
+            networkState.ConnectionState == CrOnc.ConnectionState.CONNECTED) {
+          firstConnectedNetwork = networkState;
         }
       }
-      newNetworkStateLists[type].push(state);
+      newNetworkStateLists[type].push(networkState);
     }, this);

[dpapad, 2017/01/23 19:12:54]

Nit (optional): There is no usage of |this| inside the forEach() so, you can
remove the binding to |this|.

[stevenjb, 2017/01/24 02:02:04]

Acknowledged.

 
     this.defaultNetwork = firstConnectedNetwork;
@@ -387,17 +389,18 @@ Polymer({
 
     // Push the active networks onto newActiveNetworkStates in order based on
     // device priority, creating an empty state for devices with no networks.
-    let newActiveNetworkStates = [];
+    var newActiveNetworkStates = [];
     this.activeNetworkIds_ = new Set;
-    let orderedDeviceTypes = [
+    var orderedDeviceTypes = [
       CrOnc.Type.ETHERNET, CrOnc.Type.WI_FI, CrOnc.Type.CELLULAR,
       CrOnc.Type.WI_MAX, CrOnc.Type.VPN
     ];
-    for (let type of orderedDeviceTypes) {
-      let device = newDeviceStates[type];
+    for (var t = 0; t < orderedDeviceTypes.length; ++t) {
+      var type = orderedDeviceTypes[t];
+      var device = newDeviceStates[type];
       if (!device)
         continue;
-      let state = activeNetworkStatesByType.get(type) || {GUID: '', Type: type};
+      var state = activeNetworkStatesByType.get(type) || {GUID: '', Type: type};
       if (state.Source === undefined &&
           device.State == chrome.networkingPrivate.DeviceStateType.PROHIBITED) {
         // Prohibited technologies are enforced by the device policy.