MD Settings: Eliminate use of ES6 for Chrome OS

chrome/browser/resources/settings/internet_page/network_summary.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying a summary of network states
  * by type: Ethernet, WiFi, Cellular, WiMAX, and VPN.
  */
 
 /** @typedef {chrome.networkingPrivate.DeviceStateProperties} */
@@ skipping 250 matching lines @@
       return;
     }
     // Async call, ensure id still exists.
     if (!this.activeNetworkIds_.has(id))
       return;
     if (!state) {
       this.activeNetworkIds_.delete(id);
       return;
     }
     // Find the active state for the type and update it.
-    for (let i = 0; i < this.activeNetworkStates_.length; ++i) {
+    for (var i = 0; i < this.activeNetworkStates_.length; ++i) {
       if (this.activeNetworkStates_[i].type == state.type) {
         this.activeNetworkStates_[i] = state;
         return;
       }
     }
     // Not found
     console.error('Active state not found: ' + state.Name);
   },
 
   /**
@@ skipping 54 matching lines @@
    *     properties for all visible networks.
    * @param {!Array<!DeviceStateProperties>=} opt_deviceStates
    *     Optional list of state properties for all available devices. If not
    *     defined the existing list of device states will be used.
    * @private
    */
   updateNetworkStates_: function(networkStates, opt_deviceStates) {
     var newDeviceStates;
     if (opt_deviceStates) {
       newDeviceStates = /** @type {!DeviceStateObject} */ ({});
-      for (let state of opt_deviceStates)
+      for (var s = 0; s < opt_deviceStates.length; ++s) {
+        var state = opt_deviceStates[s];
         newDeviceStates[state.Type] = state;

[dpapad, 2017/01/23 19:12:54]

Nit: No need for temporary |state| variable, since it is only used once.
newDeviceStates[state.Type] = opt_deviceStates[s];

[stevenjb, 2017/01/24 02:02:04]

Twice. state.Type and state.

+      }
     } else {
       newDeviceStates = this.deviceStates_;
     }
 
     // Clear any current networks.
     var activeNetworkStatesByType =
         /** @type {!Map<string, !CrOnc.NetworkStateProperties>} */ (new Map);
 
     // Complete list of states by type.
     /** @type {!NetworkStateListObject} */ var newNetworkStateLists = {
       Ethernet: [],
       WiFi: [],
       Cellular: [],
       WiMAX: [],
       VPN: [],
     };
 
     var firstConnectedNetwork = null;
-    networkStates.forEach(function(state) {
-      let type = state.Type;
+    networkStates.forEach(function(networkState) {
+      var type = networkState.Type;
       if (!activeNetworkStatesByType.has(type)) {
-        activeNetworkStatesByType.set(type, state);
-        if (!firstConnectedNetwork && state.Type != CrOnc.Type.VPN &&
-            state.ConnectionState == CrOnc.ConnectionState.CONNECTED) {
-          firstConnectedNetwork = state;
+        activeNetworkStatesByType.set(type, networkState);
+        if (!firstConnectedNetwork && networkState.Type != CrOnc.Type.VPN &&
+            networkState.ConnectionState == CrOnc.ConnectionState.CONNECTED) {
+          firstConnectedNetwork = networkState;
         }
       }
-      newNetworkStateLists[type].push(state);
+      newNetworkStateLists[type].push(networkState);
     }, this);

[dpapad, 2017/01/23 19:12:54]

Nit (optional): There is no usage of |this| inside the forEach() so, you can
remove the binding to |this|.

[stevenjb, 2017/01/24 02:02:04]

Acknowledged.

 
     this.defaultNetwork = firstConnectedNetwork;
 
     // Create a VPN entry in deviceStates if there are any VPN networks.
     if (newNetworkStateLists.VPN && newNetworkStateLists.VPN.length > 0) {
       newDeviceStates.VPN = /** @type {DeviceStateProperties} */ ({
         Type: CrOnc.Type.VPN,
         State: chrome.networkingPrivate.DeviceStateType.ENABLED
       });
     }
 
     // Push the active networks onto newActiveNetworkStates in order based on
     // device priority, creating an empty state for devices with no networks.
-    let newActiveNetworkStates = [];
+    var newActiveNetworkStates = [];
     this.activeNetworkIds_ = new Set;
-    let orderedDeviceTypes = [
+    var orderedDeviceTypes = [
       CrOnc.Type.ETHERNET, CrOnc.Type.WI_FI, CrOnc.Type.CELLULAR,
       CrOnc.Type.WI_MAX, CrOnc.Type.VPN
     ];
-    for (let type of orderedDeviceTypes) {
-      let device = newDeviceStates[type];
+    for (var t = 0; t < orderedDeviceTypes.length; ++t) {
+      var type = orderedDeviceTypes[t];
+      var device = newDeviceStates[type];
       if (!device)
         continue;
-      let state = activeNetworkStatesByType.get(type) || {GUID: '', Type: type};
+      var state = activeNetworkStatesByType.get(type) || {GUID: '', Type: type};
       if (state.Source === undefined &&
           device.State == chrome.networkingPrivate.DeviceStateType.PROHIBITED) {
         // Prohibited technologies are enforced by the device policy.
         state.Source = CrOnc.Source.DEVICE_POLICY;
       }
       newActiveNetworkStates.push(state);
       this.activeNetworkIds_.add(state.GUID);
     }
 
     this.deviceStates_ = newDeviceStates;
     this.networkStateLists_ = newNetworkStateLists;
     // Set activeNetworkStates last to rebuild the dom-repeat.
     this.activeNetworkStates_ = newActiveNetworkStates;
   },
 });