MD Settings: Eliminate use of ES6 for Chrome OS

chrome/browser/resources/settings/internet_page/internet_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-page' is the settings page containing internet
  * settings.
  */
 Polymer({
@@ skipping 141 matching lines @@
     chrome.send('addNetwork', [CrOnc.Type.VPN]);
   },
 
   /**
    * @param {!{model:
    *            !{item: !chrome.networkingPrivate.ThirdPartyVPNProperties},
    *        }} event
    * @private
    */
   onAddThirdPartyVpnTap_: function(event) {
-    let provider = event.model.item;
+    var provider = event.model.item;
     chrome.send('addNetwork', [CrOnc.Type.VPN, provider.ExtensionID]);
   },
 
   /**
    * chrome.management.getAll callback.
    * @param {!Array<!chrome.management.ExtensionInfo>} extensions
    * @private
    */
   onGetAllExtensions_: function(extensions) {
-    let vpnProviders = [];
-    for (var extension of extensions)
-      this.addVpnProvider_(vpnProviders, extension);
+    var vpnProviders = [];
+    for (var e = 0; e < extensions.length; ++e)

[dpapad, 2017/01/23 19:12:54]

Same (optional) nit as before here. |e| would make more sense if you were doing
the following

extensions.forEach(function(e) {
  this.addVpnProvider_(vpnProviders, e);
}.bind(this));

such that |e| holds an item from the array instead of an index.

[stevenjb, 2017/01/24 02:02:04]

Done.

+      this.addVpnProvider_(vpnProviders, extensions[e]);
     this.thirdPartyVpnProviders_ = vpnProviders;
   },
 
   /**
    * If |extension| is a third-party VPN provider, add it to |vpnProviders|.
    * @param {!Array<!chrome.networkingPrivate.ThirdPartyVPNProperties>}
    *     vpnProviders
    * @param {!chrome.management.ExtensionInfo} extension
    * @private
    */
@@ skipping 56 matching lines @@
   },
 
   /**
    * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider
    * @return {string}
    */
   getAddThirdParrtyVpnLabel_: function(provider) {
     return this.i18n('internetAddThirdPartyVPN', provider.ProviderName);
   }
 });