Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Side by Side Diff: services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h

Issue 2651443002: Fix potential shutdown deadlock in UI service (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_ 5 #ifndef SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_
6 #define SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_ 6 #define SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <set>
9 #include <vector> 10 #include <vector>
10 11
11 #include "base/macros.h" 12 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 13 #include "base/memory/ref_counted.h"
13 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
14 #include "base/threading/thread.h" 15 #include "base/threading/thread.h"
15 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h" 16 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h"
16 #include "services/ui/public/interfaces/gpu.mojom.h" 17 #include "services/ui/public/interfaces/gpu.mojom.h"
17 18
18 namespace base { 19 namespace base {
19 class WaitableEvent; 20 class WaitableEvent;
20 } 21 }
21 22
22 namespace ui { 23 namespace ui {
23 24
24 class ClientGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager { 25 class ClientGpuMemoryBufferManager : public gpu::GpuMemoryBufferManager {
25 public: 26 public:
26 explicit ClientGpuMemoryBufferManager(mojom::GpuPtr gpu); 27 explicit ClientGpuMemoryBufferManager(mojom::GpuPtr gpu);
27 ~ClientGpuMemoryBufferManager() override; 28 ~ClientGpuMemoryBufferManager() override;
28 29
29 private: 30 private:
30 void InitThread(mojom::GpuPtrInfo gpu_info); 31 void InitThread(mojom::GpuPtrInfo gpu_info);
31 void TearDownThread(); 32 void TearDownThread();
33 void DisconnectGpuOnThread();
32 void AllocateGpuMemoryBufferOnThread(const gfx::Size& size, 34 void AllocateGpuMemoryBufferOnThread(const gfx::Size& size,
33 gfx::BufferFormat format, 35 gfx::BufferFormat format,
34 gfx::BufferUsage usage, 36 gfx::BufferUsage usage,
35 gfx::GpuMemoryBufferHandle* handle, 37 gfx::GpuMemoryBufferHandle* handle,
36 base::WaitableEvent* wait); 38 base::WaitableEvent* wait);
39 void OnGpuMemoryBufferAllocatedOnThread(
40 gfx::GpuMemoryBufferHandle* ret_handle,
41 base::WaitableEvent* wait,
42 const gfx::GpuMemoryBufferHandle& handle);
37 void DeletedGpuMemoryBuffer(gfx::GpuMemoryBufferId id, 43 void DeletedGpuMemoryBuffer(gfx::GpuMemoryBufferId id,
38 const gpu::SyncToken& sync_token); 44 const gpu::SyncToken& sync_token);
39 45
40 // Overridden from gpu::GpuMemoryBufferManager: 46 // Overridden from gpu::GpuMemoryBufferManager:
41 std::unique_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer( 47 std::unique_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBuffer(
42 const gfx::Size& size, 48 const gfx::Size& size,
43 gfx::BufferFormat format, 49 gfx::BufferFormat format,
44 gfx::BufferUsage usage, 50 gfx::BufferUsage usage,
45 gpu::SurfaceHandle surface_handle) override; 51 gpu::SurfaceHandle surface_handle) override;
46 void SetDestructionSyncToken(gfx::GpuMemoryBuffer* buffer, 52 void SetDestructionSyncToken(gfx::GpuMemoryBuffer* buffer,
47 const gpu::SyncToken& sync_token) override; 53 const gpu::SyncToken& sync_token) override;
54
48 int counter_ = 0; 55 int counter_ = 0;
49 // TODO(sad): Explore the option of doing this from an existing thread. 56 // TODO(sad): Explore the option of doing this from an existing thread.
50 base::Thread thread_; 57 base::Thread thread_;
51 mojom::GpuPtr gpu_; 58 mojom::GpuPtr gpu_;
52 base::WeakPtr<ClientGpuMemoryBufferManager> weak_ptr_; 59 base::WeakPtr<ClientGpuMemoryBufferManager> weak_ptr_;
60 std::set<base::WaitableEvent*> pending_allocation_waiters_;
53 base::WeakPtrFactory<ClientGpuMemoryBufferManager> weak_ptr_factory_; 61 base::WeakPtrFactory<ClientGpuMemoryBufferManager> weak_ptr_factory_;
54 62
55 DISALLOW_COPY_AND_ASSIGN(ClientGpuMemoryBufferManager); 63 DISALLOW_COPY_AND_ASSIGN(ClientGpuMemoryBufferManager);
56 }; 64 };
57 65
58 } // namespace ui 66 } // namespace ui
59 67
60 #endif // SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_ 68 #endif // SERVICES_UI_PUBLIC_CPP_GPU_CLIENT_GPU_MEMORY_BUFFER_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698