Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4632)

Unified Diff: cc/tiles/picture_layer_tiling.h

Issue 2651413004: cc: Fix tile priority inversion in picture layer tiling. (Closed)
Patch Set: whyyoucrash: update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/tiles/picture_layer_tiling.cc » ('j') | cc/tiles/picture_layer_tiling.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/picture_layer_tiling.h
diff --git a/cc/tiles/picture_layer_tiling.h b/cc/tiles/picture_layer_tiling.h
index 962ae8d776bf636dbc55c082017b81cbf095873a..d3295da51c84fd9ced0d3a52b4713ddf83bd8bbb 100644
--- a/cc/tiles/picture_layer_tiling.h
+++ b/cc/tiles/picture_layer_tiling.h
@@ -157,8 +157,11 @@ class CC_EXPORT PictureLayerTiling {
}
void UpdateAllRequiredStateForTesting() {
- for (const auto& key_tile_pair : tiles_)
- UpdateRequiredStatesOnTile(key_tile_pair.second.get());
+ for (const auto& key_tile_pair : tiles_) {
+ Tile* tile = key_tile_pair.second.get();
+ tile->set_required_for_activation(IsTileRequiredForActivation(tile));
+ tile->set_required_for_draw(IsTileRequiredForDraw(tile));
+ }
}
std::map<const Tile*, PrioritizedTile>
UpdateAndGetAllPrioritizedTilesForTesting() const;
@@ -288,7 +291,6 @@ class CC_EXPORT PictureLayerTiling {
Tile::CreateInfo CreateInfoForTile(int i, int j) const;
bool ShouldCreateTileAt(const Tile::CreateInfo& info) const;
bool IsTileOccluded(const Tile* tile) const;
- void UpdateRequiredStatesOnTile(Tile* tile) const;
PrioritizedTile MakePrioritizedTile(
Tile* tile,
PriorityRectType priority_rect_type) const;
« no previous file with comments | « no previous file | cc/tiles/picture_layer_tiling.cc » ('j') | cc/tiles/picture_layer_tiling.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698