Report errors from ChromiumEnv::GetChildren in Posix.

base/platform_file.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PLATFORM_FILE_H_
 #define BASE_PLATFORM_FILE_H_
 
 #include "build/build_config.h"
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 37 matching lines @@
   PLATFORM_FILE_WRITE_ATTRIBUTES = 1 << 14,  // Used on Windows only
 
   PLATFORM_FILE_SHARE_DELETE = 1 << 15,      // Used on Windows only
 
   PLATFORM_FILE_TERMINAL_DEVICE = 1 << 16,   // Serial port flags
   PLATFORM_FILE_BACKUP_SEMANTICS = 1 << 17,  // Used on Windows only
 
   PLATFORM_FILE_EXECUTE = 1 << 18,           // Used on Windows only
 };
 
+// This enum has been recorded in multiple histograms. If the order of the
+// fields needs to change, please ensure that those histograms are obsolete or
+// have been moved to a different enum.

[dgrogan, 2013/10/18 21:54:10]

thakis@, please take a look

+//
 // PLATFORM_FILE_ERROR_ACCESS_DENIED is returned when a call fails because of
 // a filesystem restriction. PLATFORM_FILE_ERROR_SECURITY is returned when a
 // browser policy doesn't allow the operation to be executed.
 enum PlatformFileError {
   PLATFORM_FILE_OK = 0,
   PLATFORM_FILE_ERROR_FAILED = -1,
   PLATFORM_FILE_ERROR_IN_USE = -2,
   PLATFORM_FILE_ERROR_EXISTS = -3,
   PLATFORM_FILE_ERROR_NOT_FOUND = -4,
   PLATFORM_FILE_ERROR_ACCESS_DENIED = -5,
@@ skipping 47 matching lines @@
   base::Time creation_time;
 };
 
 #if defined(OS_WIN)
 typedef HANDLE PlatformFile;
 const PlatformFile kInvalidPlatformFileValue = INVALID_HANDLE_VALUE;
 PlatformFileError LastErrorToPlatformFileError(DWORD saved_errno);
 #elif defined(OS_POSIX)
 typedef int PlatformFile;
 const PlatformFile kInvalidPlatformFileValue = -1;
-PlatformFileError ErrnoToPlatformFileError(int saved_errno);
+BASE_EXPORT PlatformFileError ErrnoToPlatformFileError(int saved_errno);
 #endif
 
 // Creates or opens the given file. If |created| is provided, it will be set to
 // true if a new file was created [or an old one truncated to zero length to
 // simulate a new file, which can happen with PLATFORM_FILE_CREATE_ALWAYS], and
 // false otherwise.  |error| can be NULL.
 //
 // This function fails with 'access denied' if the |name| contains path
 // traversal ('..') components.
 BASE_EXPORT PlatformFile CreatePlatformFile(const FilePath& name,
@@ skipping 135 matching lines @@
     return temp;
   }
 
  private:
   PlatformFile* value_;
 };
 
 }  // namespace base
 
 #endif  // BASE_PLATFORM_FILE_H_