Chromium Code Reviews| Index: chrome/browser/resources/settings/settings_menu/settings_menu.js |
| diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js |
| index 590b33167d96fedbed6013032674a177c7b1d9bc..b2d736cad86e26365df3ed61409f7548a688b0d0 100644 |
| --- a/chrome/browser/resources/settings/settings_menu/settings_menu.js |
| +++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js |
| @@ -73,7 +73,10 @@ Polymer({ |
| * @private |
| */ |
| openPage_: function(event) { |
| - var route = settings.getRouteForPath(event.currentTarget.dataset.path); |
| + event.preventDefault(); |
| + var path = event.currentTarget.href.substr( |
|
Dan Beam
2017/02/06 17:28:12
btw, there's a URL class
new URL(event.currentTar
hcarmona
2017/02/10 19:27:34
Sweet! Using URL.
|
| + event.currentTarget.baseURI.length - 1); |
|
dschuyler
2017/02/02 20:46:53
My guess is that line 77 is cutting off any query
hcarmona
2017/02/10 19:27:34
Changed to use URL
|
| + var route = settings.getRouteForPath(path); |
| assert(route, 'settings-menu has an an entry with an invalid path'); |
| settings.navigateTo( |
| route, /* dynamicParams */ null, /* removeSearch */ true); |