Issue 2651273004: Fixed issue where initial 1KB zone buffer was not being accounted for when tracking thread zone me…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2651273004: Fixed issue where initial 1KB zone buffer was not being accounted for when tracking thread zone me… (Closed)

Created:
3 years, 10 months ago by bkonyi

Modified:
3 years, 10 months ago

Reviewers:
zra, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed issue where initial 1KB zone buffer was not being accounted for when tracking thread zone memory usage. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/171a27b79cccf58edf8986ac37041a3f42f58231

Patch Set 1 #

Total comments: 1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	runtime/vm/thread.cc	View		2 chunks	+13 lines, -2 lines	1 comment	Download
	M	runtime/vm/zone.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

LGTM w/c https://codereview.chromium.org/2651273004/diff/1/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/2651273004/diff/1/runtime/vm/thread.cc#newcode143 runtime/vm/thread.cc:143: while (current != NULL) { is there ...

3 years, 10 months ago (2017-01-31 17:12:41 UTC) #3

bkonyi

3 years, 10 months ago (2017-01-31 22:32:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
171a27b79cccf58edf8986ac37041a3f42f58231 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages