Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 2651233002: Enable download home by default (Closed)
Patch Set: comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
index d47702ee6c9a696b22dca550994f7d76c69fb468..eb3327efb05eb3dc0b5815f3ed7d5abec4952e4a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
@@ -80,6 +80,8 @@ public class DownloadManagerService extends BroadcastReceiver implements
// Wait 10 seconds to resume all downloads, so that we won't impact tab loading.
private static final long RESUME_DELAY_MILLIS = 10000;
private static final int UNKNOWN_DOWNLOAD_STATUS = -1;
+ private static final String PREF_IS_DOWNLOAD_HOME_ENABLED =
+ "org.chromium.chrome.browser.download.IS_DOWNLOAD_HOME_ENABLED";
// Values for the histogram MobileDownloadResumptionCount.
private static final int UMA_DOWNLOAD_RESUMPTION_MANUAL_PAUSE = 0;
@@ -242,6 +244,8 @@ public class DownloadManagerService extends BroadcastReceiver implements
long updateDelayInMillis) {
mContext = context;
mSharedPrefs = ContextUtils.getAppSharedPreferences();
+ // Clean up unused shared prefs. TODO(qinmin): remove this after M58.
Theresa 2017/01/25 22:56:49 nit: What if the user is updating from M56 to M59
qinmin 2017/01/26 00:18:12 Unfortunately, that will leave the sharedpref uncl
Theresa 2017/01/26 00:22:21 Why not just leave this line until a more distant
qinmin 2017/01/26 00:39:53 ok, changed this to M61, that is 30 weeks since M5
+ mSharedPrefs.edit().remove(PREF_IS_DOWNLOAD_HOME_ENABLED).apply();
mDownloadNotifier = downloadNotifier;
mUpdateDelayInMillis = updateDelayInMillis;
mHandler = handler;

Powered by Google App Engine
This is Rietveld 408576698