Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 265123003: DRAFT CL: Check that we already know the renderer's page ID (outside commit). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index fea916e68d920a2ffc7b2c26ea8388443caaedcf..e7e6f962ef5b9fc6081cd86edd3e90b3b46c0dc3 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2805,8 +2805,11 @@ void WebContentsImpl::OnDidDownloadImage(
void WebContentsImpl::OnUpdateFaviconURL(
int32 page_id,
const std::vector<FaviconURL>& candidates) {
+ // TODO(creis): It is not safe to use page_id here. It looks unused, so clear
+ // it out.
+ int32 unused = -1;
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
- DidUpdateFaviconURL(page_id, candidates));
+ DidUpdateFaviconURL(unused, candidates));
}
void WebContentsImpl::OnMediaPlayingNotification(int64 player_cookie,
@@ -2843,8 +2846,10 @@ void WebContentsImpl::OnMediaPausedNotification(int64 player_cookie) {
}
void WebContentsImpl::OnFirstVisuallyNonEmptyPaint(int32 page_id) {
+ // TODO(creis): This shouldn't have a page_id. It's unused, so remove it.
+ int32 unused = -1;
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
- DidFirstVisuallyNonEmptyPaint(page_id));
+ DidFirstVisuallyNonEmptyPaint(unused));
}
void WebContentsImpl::DidChangeVisibleSSLState() {
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698