Issue 2651193002: Always pass "allocate: true" when converting URIs to paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2651193002: Always pass "allocate: true" when converting URIs to paths. (Closed)

Created:
3 years, 11 months ago by Paul Berry

Modified:
3 years, 11 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Always pass "allocate: true" when converting URIs to paths. There's no need to special case the handling of "dart:" URIs. Eventually we will need the "allocate:" behavior for all URIs anyhow, because we won't have a pre-traversal of the import graph to populate the FileRepository. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7d314c99bbae04914b8a85841adf667f5f858320

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 11 months ago (2017-01-25 17:22:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7d314c99bbae04914b8a85841adf667f5f858320 (presubmit successful).