Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2432)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2651163002: Add UMA for autoblocking and embargoing. (Closed)
Patch Set: Review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index c00f3e7aa503570ad94c778a64b0b4923857aa9d..57d3479adb7ea1dc0731cbadb849391a509655f1 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -316,6 +316,11 @@ void PermissionContextBase::PermissionDecided(
// The permission has been embargoed, so it is blocked for this permission
// request, but not persisted.
content_setting = CONTENT_SETTING_BLOCK;
raymes 2017/02/03 19:56:20 This is slightly orthogonal to this CL, but I thin
+ } else {
+ // If a decision was made, and it did not exceed the number of allowable
+ // dismissals, then it cannot have been embargoed.
+ PermissionUmaUtil::RecordPermissionEmbargoReason(
+ PermissionEmbargoReason::NOT_EMBARGOED);
}
NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,

Powered by Google App Engine
This is Rietveld 408576698