Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7287)

Unified Diff: chrome/browser/permissions/permission_context_base_unittest.cc

Issue 2651163002: Add UMA for autoblocking and embargoing. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base_unittest.cc
diff --git a/chrome/browser/permissions/permission_context_base_unittest.cc b/chrome/browser/permissions/permission_context_base_unittest.cc
index 7e09f909dd4ebdade53b5c46aaaaef0b860acfa2..9e5cbdf204c3c92fa009a16f7468a12852efb007 100644
--- a/chrome/browser/permissions/permission_context_base_unittest.cc
+++ b/chrome/browser/permissions/permission_context_base_unittest.cc
@@ -288,7 +288,8 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
ASSERT_EQ(1u, permission_context.decisions().size());
EXPECT_EQ(decision, permission_context.decisions()[0]);
EXPECT_TRUE(permission_context.tab_context_updated());
-
+ histograms.ExpectBucketCount("Permissions.AutoBlocker.EmbargoReason",
+ PermissionEmbargoReason::NOT_EMBARGOED, 1);
std::string decision_string;
if (decision == CONTENT_SETTING_ALLOW)
decision_string = "Accepted";
@@ -352,6 +353,9 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
"Permissions.Prompt.Dismissed.PriorDismissCount." +
PermissionUtil::GetPermissionString(permission_type),
i, 1);
+ histograms.ExpectBucketCount("Permissions.AutoBlocker.EmbargoReason",
+ PermissionEmbargoReason::NOT_EMBARGOED,
+ i + 1);
ASSERT_EQ(1u, permission_context.decisions().size());
EXPECT_EQ(expected, permission_context.decisions()[0]);
EXPECT_TRUE(permission_context.tab_context_updated());
@@ -376,6 +380,9 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
EXPECT_EQ(CONTENT_SETTING_BLOCK,
permission_context.GetPermissionStatus(url, url));
+ histograms.ExpectBucketCount("Permissions.AutoBlocker.EmbargoReason",
+ PermissionEmbargoReason::REPEATED_DISMISSALS,
+ 1);
}
void TestBlockOnSeveralDismissals_TestContent() {
@@ -406,6 +413,9 @@ class PermissionContextBaseTests : public ChromeRenderViewHostTestHarness {
i + 1);
histograms.ExpectBucketCount(
"Permissions.Prompt.Dismissed.PriorDismissCount.Geolocation", i, 1);
+ histograms.ExpectBucketCount("Permissions.AutoBlocker.EmbargoReason",
+ PermissionEmbargoReason::NOT_EMBARGOED,
+ i + 1);
ASSERT_EQ(1u, permission_context.decisions().size());
EXPECT_EQ(CONTENT_SETTING_ASK, permission_context.decisions()[0]);
EXPECT_TRUE(permission_context.tab_context_updated());

Powered by Google App Engine
This is Rietveld 408576698