third_party/WebKit/Source/core/layout/line/InlineBox.cpp - Issue 2651123005: Place ellipsis correctly in presence of list markers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

Issue 2651123005: Place ellipsis correctly in presence of list markers (Closed)

Patch Set: bug 645938 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp

index 97ae55243db8cc510f9eb2ca5260d0f5ce307bd7..7acdb22dc3cdc41c3b1964250ba65fae6421248c 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.cpp

@@ -308,7 +308,9 @@ bool InlineBox::canAccommodateEllipsis(bool ltr,

int blockEdge,

int ellipsisWidth) const {

// Non-atomic inline-level elements can always accommodate an ellipsis.

- if (!getLineLayoutItem().isAtomicInlineLevel())

+ // Skip list markers and try the next box.

+ if (!getLineLayoutItem().isAtomicInlineLevel() ||

+ getLineLayoutItem().isListMarker())

return true;

IntRect boxRect(x().toInt(), 0, m_logicalWidth.toInt(), 10);