Issue 28387. Test for search of classes defined in SDK.

Issue 28387. Test for search of classes defined in SDK.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28387

Committed: https://github.com/dart-lang/sdk/commit/ebe04d131bea289b976b200c0455ebc40c71db72

[Brian Wilkerson, 2017-01-25 14:52:42]

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/search_test.dart (right):

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/search_test.dart:229: // IDEA performs
search always at declaration, never at reference.
I don't understand the second line of this comment. In what way is this test
specific to IntelliJ?

[scheglov, 2017-01-25 15:02:20]

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/search_test.dart (right):

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/search_test.dart:229: // IDEA performs
search always at declaration, never at reference.
On 2017/01/25 14:52:42, Brian Wilkerson wrote:
> I don't understand the second line of this comment. In what way is this test
> specific to IntelliJ?

Yes, kind of.

When you search on Random in "Random v1", IDEA uses navigation notification
results to find out that Random is defined in /your/sdk/lib/math/random.dart @
1234. Then it issues the search request in this SDK file at 1234.

So, this test tries to do the same.

[Brian Wilkerson, 2017-01-25 15:09:28]

lgtm

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/search_test.dart (right):

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/search_test.dart:229: // IDEA performs
search always at declaration, never at reference.
Ok. It makes perfect sense to test that code path if we have a client using it.
It also makes sense to test the more direct path because server should also
support searching from a use site. Please either add the test or a TODO so we
don't forget to add it later.

[scheglov, 2017-01-25 16:38:57]

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/search_test.dart (right):

https://codereview.chromium.org/2651103004/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/search_test.dart:229: // IDEA performs
search always at declaration, never at reference.
On 2017/01/25 15:09:27, Brian Wilkerson wrote:
> Ok. It makes perfect sense to test that code path if we have a client using
it.
> It also makes sense to test the more direct path because server should also
> support searching from a use site. Please either add the test or a TODO so we
> don't forget to add it later.

Done.

[scheglov, 2017-01-25 16:39:49]

Description was changed from

==========
Issue 28387. Test for search of classes defined in SDK.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28387
==========

to

==========
Issue 28387. Test for search of classes defined in SDK.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28387

Committed:
https://github.com/dart-lang/sdk/commit/ebe04d131bea289b976b200c0455ebc40c71db72
==========

[scheglov, 2017-01-25 16:39:50]

Committed patchset #1 (id:1) manually as
ebe04d131bea289b976b200c0455ebc40c71db72 (presubmit successful).