Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 26511002: Revert 227477 "Refactored loading of applications / extensions i..." (Closed)

Created:
7 years, 2 months ago by Timur Iskhodzhanov
Modified:
7 years, 2 months ago
Reviewers:
dvh
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 227477 "Refactored loading of applications / extensions i..." as it has introduced data races. BUG=304180 > Refactored loading of applications / extensions icons. > Added ImageLoader::LoadExtensionIconAsync() and ImageLoader::LoadExtensionIconDataURLAsync(). > Moved all apps / extension loading code to ImageLoader. > > BUG=297298, 297301, 304180 > > Review URL: https://codereview.chromium.org/26161002 TBR=dvh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227520

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
Timur Iskhodzhanov
7 years, 2 months ago (2013-10-08 16:00:45 UTC) #1
Timur Iskhodzhanov
Committed patchset #1 manually as r227520.
7 years, 2 months ago (2013-10-08 16:00:59 UTC) #2
dvh
7 years, 2 months ago (2013-10-08 21:57:52 UTC) #3
Message was sent while issue was closed.
On 2013/10/08 16:00:59, Timur Iskhodzhanov wrote:
> Committed patchset #1 manually as r227520.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698