DevTools: Remove files in the navigator when they are deleted externally

third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 29 matching lines @@
     /** @type {!Map<number, function(!Array.<string>)>} */
     this._callbacks = new Map();
     /** @type {!Map<number, !Common.Progress>} */
     this._progresses = new Map();
 
     InspectorFrontendHost.events.addEventListener(
         InspectorFrontendHostAPI.Events.FileSystemRemoved, this._onFileSystemRemoved, this);
     InspectorFrontendHost.events.addEventListener(
         InspectorFrontendHostAPI.Events.FileSystemAdded, this._onFileSystemAdded, this);
     InspectorFrontendHost.events.addEventListener(
-        InspectorFrontendHostAPI.Events.FileSystemFilesChanged, this._onFileSystemFilesChanged, this);
+        InspectorFrontendHostAPI.Events.FileSystemFilesChangedAddedRemoved, this._onFileSystemFilesChanged, this);
     InspectorFrontendHost.events.addEventListener(
         InspectorFrontendHostAPI.Events.IndexingTotalWorkCalculated, this._onIndexingTotalWorkCalculated, this);
     InspectorFrontendHost.events.addEventListener(
         InspectorFrontendHostAPI.Events.IndexingWorked, this._onIndexingWorked, this);
     InspectorFrontendHost.events.addEventListener(
         InspectorFrontendHostAPI.Events.IndexingDone, this._onIndexingDone, this);
     InspectorFrontendHost.events.addEventListener(
         InspectorFrontendHostAPI.Events.SearchCompleted, this._onSearchCompleted, this);
 
     this._initExcludePatterSetting();
@@ skipping 99 matching lines @@
       return;
     this._fileSystems.delete(fileSystemPath);
     isolatedFileSystem.fileSystemRemoved();
     this.dispatchEventToListeners(Workspace.IsolatedFileSystemManager.Events.FileSystemRemoved, isolatedFileSystem);
   }
 
   /**
    * @param {!Common.Event} event
    */
   _onFileSystemFilesChanged(event) {
-    var embedderPaths = /** @type {!Array<string>} */ (event.data);
-    var paths = embedderPaths.map(embedderPath => Common.ParsedURL.platformPathToURL(embedderPath));
+    var paths = /** @type {!Workspace.IsolatedFileSystemManager.FilesChangedData} */ (event.data);
+    for (var pathType in paths)

[lushnikov, 2017/01/26 01:10:57]

let's write this explicitly

var changedPaths = paths.changed.map(...)
var addedPaths = ..
var removedPaths = ..

Only one line more, but so much easier to read

[einbinder, 2017/01/26 22:06:14]

Done.

+      paths[pathType] = paths[pathType].map(embedderPath => Common.ParsedURL.platformPathToURL(embedderPath));
     this.dispatchEventToListeners(Workspace.IsolatedFileSystemManager.Events.FileSystemFilesChanged, paths);
   }
 
   /**
    * @return {!Array<!Workspace.IsolatedFileSystem>}
    */
   fileSystems() {
     return this._fileSystems.valuesArray();
   }
 
@@ skipping 109 matching lines @@
     if (!callback)
       return;
     callback.call(null, files);
     this._callbacks.delete(requestId);
   }
 };
 
 /** @typedef {!{fileSystemName: string, rootURL: string, fileSystemPath: string}} */
 Workspace.IsolatedFileSystemManager.FileSystem;
 
+/** @typedef {!{changed:!Array<string>, added:!Array<string>, removed:!Array<string>}} */
+Workspace.IsolatedFileSystemManager.FilesChangedData;
+
 /** @enum {symbol} */
 Workspace.IsolatedFileSystemManager.Events = {
   FileSystemAdded: Symbol('FileSystemAdded'),
   FileSystemRemoved: Symbol('FileSystemRemoved'),
   FileSystemFilesChanged: Symbol('FileSystemFilesChanged'),
   ExcludedFolderAdded: Symbol('ExcludedFolderAdded'),
   ExcludedFolderRemoved: Symbol('ExcludedFolderRemoved')
 };
 
 Workspace.IsolatedFileSystemManager._lastRequestId = 0;
 
 /**
  * @type {!Workspace.IsolatedFileSystemManager}
  */
 Workspace.isolatedFileSystemManager;