Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: src/wasm/wasm-interpreter.cc

Issue 2651043004: [wasm] Add inspector test for stepping (Closed)
Patch Set: Beautification Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-debug.cc ('k') | test/inspector/debugger/wasm-stepping.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-interpreter.cc
diff --git a/src/wasm/wasm-interpreter.cc b/src/wasm/wasm-interpreter.cc
index 682a538081771b2ec043a4f3f5188e47ce19cc2b..0c2886e7b1a21de066f2f187b26f576034dfa9df 100644
--- a/src/wasm/wasm-interpreter.cc
+++ b/src/wasm/wasm-interpreter.cc
@@ -1203,13 +1203,11 @@ class ThreadImpl {
// skip breakpoint by switching on original code.
skip = "[skip] ";
} else {
- state_ = WasmInterpreter::PAUSED;
TRACE("@%-3zu: [break] %-24s:", pc,
WasmOpcodes::OpcodeName(static_cast<WasmOpcode>(orig)));
TraceValueStack();
TRACE("\n");
- break_pc_ = pc;
- return CommitPc(pc);
+ break;
}
}
@@ -1638,6 +1636,9 @@ class ThreadImpl {
pc += len;
}
+ // Set break_pc_, even though we might have stopped because max was reached.
+ // We don't want to stop after executing zero instructions next time.
+ break_pc_ = pc;
state_ = WasmInterpreter::PAUSED;
CommitPc(pc);
}
« no previous file with comments | « src/wasm/wasm-debug.cc ('k') | test/inspector/debugger/wasm-stepping.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698