Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2651043003: ADD TEAM/COMPONENT (Closed)

Created:
3 years, 11 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, zea+watch_chromium.org, ntp-dev+reviews_chromium.org, mlamouri+watch-geolocation_chromium.org, mvanouwerkerk+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, agrieve+watch_chromium.org, jam, timvolodine, abarth-chromium, haraken, mlamouri+watch-blink_chromium.org, noyau+watch_chromium.org, Michael van Ouwerkerk, blink-reviews, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905

Patch Set 1 #

Total comments: 4

Patch Set 2 : update TEAM/COMPONENT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/android/java/res/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/geolocation/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M components/gcm_driver/android/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M device/geolocation/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M device/geolocation/public/interfaces/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M device/vibration/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 11 months ago (2017-01-24 20:34:20 UTC) #1
Bernhard Bauer
https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/res/OWNERS File chrome/android/java/res/OWNERS (right): https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/res/OWNERS#newcode15 chrome/android/java/res/OWNERS:15: # COMPONENT: Infra>Client>Android Infra>Client is for infrastructure. I don't ...
3 years, 11 months ago (2017-01-25 18:08:14 UTC) #3
ymzhang1
https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/res/OWNERS File chrome/android/java/res/OWNERS (right): https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/res/OWNERS#newcode15 chrome/android/java/res/OWNERS:15: # COMPONENT: Infra>Client>Android On 2017/01/25 18:08:14, Bernhard Bauer wrote: ...
3 years, 11 months ago (2017-01-25 18:20:51 UTC) #5
sshruthi1
3 years, 11 months ago (2017-01-25 18:32:34 UTC) #6 
On 2017/01/25 18:20:51, ymzhang1 wrote:
>
https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/res/OWNERS
> File chrome/android/java/res/OWNERS (right):
> 
>
https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/res/OWN...
> chrome/android/java/res/OWNERS:15: # COMPONENT: Infra>Client>Android
> On 2017/01/25 18:08:14, Bernhard Bauer wrote:
> > Infra>Client is for infrastructure. I don't think we really have a component
> for
> > Android UI -- should we add one?
> 
> +Shruthi

Sounds like a good idea. Could you please make a request here with details, and
we can pick it up from there:
https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request
Feel free to ping me if the component creation blocks this CL.

> 
>
https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/src/org...
> File chrome/android/java/src/org/chromium/chrome/browser/ntp/OWNERS (right):
> 
>
https://codereview.chromium.org/2651043003/diff/1/chrome/android/java/src/org...
> chrome/android/java/src/org/chromium/chrome/browser/ntp/OWNERS:6: # COMPONENT:
> Infra>Client>Android
> On 2017/01/25 18:08:14, Bernhard Bauer wrote:
> > UI>Browser>NewTabPage would be more appropriate.
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698