Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2651033004: Fix Windows debug assertion when cancelling pending i/o (Closed)

Created:
3 years, 11 months ago by Florian Schneider
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Windows debug assertion when cancelling pending i/o When no pending i/o requests are found, CancelIoEx returns ERROR_NOT_FOUND. This is ok, since there is nothing else to do before closing the handle. Related to #22940. TBR=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/c1e4e8ef72e9120aa4fe19187c67f8c354e73488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/eventhandler_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
3 years, 11 months ago (2017-01-25 01:31:53 UTC) #2
Florian Schneider
TBR
3 years, 11 months ago (2017-01-25 01:32:56 UTC) #4
Florian Schneider
Committed patchset #1 (id:1) manually as c1e4e8ef72e9120aa4fe19187c67f8c354e73488 (presubmit successful).
3 years, 11 months ago (2017-01-25 01:33:58 UTC) #6
zra
3 years, 11 months ago (2017-01-25 05:58:30 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698