Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/gn/args.cc

Issue 2651023004: Display override values in GN args help. (Closed)
Patch Set: Spellinc Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/args.h ('k') | tools/gn/command_args.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/args.cc
diff --git a/tools/gn/args.cc b/tools/gn/args.cc
index ceeb46b7179ff661620d0d5e98dc35e3a3f6b8ac..3bb40b415743d7fc422230e56adf898ceba5c43e 100644
--- a/tools/gn/args.cc
+++ b/tools/gn/args.cc
@@ -84,6 +84,21 @@ void RemoveDeclaredOverrides(const Scope::KeyValueMap& declared_arguments,
} // namespace
+Args::ValueWithOverride::ValueWithOverride()
+ : default_value(),
+ has_override(false),
+ override_value() {
+}
+
+Args::ValueWithOverride::ValueWithOverride(const Value& def_val)
+ : default_value(def_val),
+ has_override(false),
+ override_value() {
+}
+
+Args::ValueWithOverride::~ValueWithOverride() {
+}
+
Args::Args() {
}
@@ -124,11 +139,6 @@ const Value* Args::GetArgOverride(const char* name) const {
return &found->second;
}
-Scope::KeyValueMap Args::GetAllOverrides() const {
- base::AutoLock lock(lock_);
- return all_overrides_;
-}
-
void Args::SetupRootScope(Scope* dest,
const Scope::KeyValueMap& toolchain_overrides) const {
base::AutoLock lock(lock_);
@@ -254,12 +264,27 @@ bool Args::VerifyAllOverridesUsed(Err* err) const {
return false;
}
-void Args::MergeDeclaredArguments(Scope::KeyValueMap* dest) const {
+Args::ValueWithOverrideMap Args::GetAllArguments() const {
+ ValueWithOverrideMap result;
+
base::AutoLock lock(lock_);
+
+ // Default values.
for (const auto& map_pair : declared_arguments_per_toolchain_) {
for (const auto& arg : map_pair.second)
- (*dest)[arg.first] = arg.second;
+ result.insert(std::make_pair(arg.first, ValueWithOverride(arg.second)));
}
+
+ // Merge in overrides.
+ for (const auto& over : overrides_) {
+ auto found = result.find(over.first);
+ if (found != result.end()) {
+ found->second.has_override = true;
+ found->second.override_value = over.second;
+ }
+ }
+
+ return result;
}
void Args::SetSystemVarsLocked(Scope* dest) const {
« no previous file with comments | « tools/gn/args.h ('k') | tools/gn/command_args.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698