Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2651013004: MD History: Improve styling of grouped history toolbar during page load (Closed)

Created:
3 years, 11 months ago by tsergeant
Modified:
3 years, 10 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Improve styling of grouped history toolbar during page load This improves the styling of the grouped toolbar between when the main app bundle loads and the lazy-loaded element bundle is finished loading. In particular, the grouped offset buttons are now correctly colored white instead of black, and the All/Week/Month tabs are hidden until they are fully resolved. These changes are only visible when grouped history mode is explicitly enabled -- they do not have any affect on the regular page. BUG=589357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 1 8 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
tsergeant
3 years, 10 months ago (2017-02-02 02:40:46 UTC) #4
calamity
3 years, 10 months ago (2017-02-06 03:47:24 UTC) #8
Looks deleted to me.

Powered by Google App Engine
This is Rietveld 408576698