Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2650973006: Check |m_inspectedFrames| in InspectorNetworkAgent to avoid crashes. (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check |m_inspectedFrames| in InspectorNetworkAgent to avoid crashes. Some methods of InspectorNetworkAgent is not supported in worker thread. So this CL check |m_inspectedFrames| not to call those methods. BUG=685493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
horo
pfeldman@ Could you please review this?
3 years, 11 months ago (2017-01-26 04:58:36 UTC) #4
pfeldman1
But those were not instrumented, what code is calling into them? Also, you add these ...
3 years, 11 months ago (2017-01-26 05:39:48 UTC) #5
horo
3 years, 11 months ago (2017-01-26 05:50:15 UTC) #6
On 2017/01/26 05:39:48, pfeldman1 wrote:
> But those were not instrumented, what code is calling into them? Also, you add
> these gards in methods that don't use the field you guard against, which makes
> the code look weird. Let's revert and do the proper review of the fix.

OK I will land the revert patch.
https://codereview.chromium.org/2654433012/

Powered by Google App Engine
This is Rietveld 408576698