chrome/browser/safe_browsing/safe_browsing_service.cc - Issue 2650973005: Componentize ping_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 2650973005: Componentize ping_manager (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_service.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc

index a391b2560a902f9d57d6dbf867a2254c7d9b484c..2ecf2d09f5dcbd4740b732d6729c42d351ee0ecf 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc

@@ -78,7 +78,6 @@

#include "chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h"

#include "chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.h"

#include "chrome/browser/safe_browsing/protocol_manager.h"

-#include "chrome/browser/safe_browsing/protocol_manager_helper.h"

#endif

using content::BrowserThread;

@@ -522,7 +521,7 @@ SafeBrowsingService::GetV4ProtocolConfig() const {

return V4ProtocolConfig(

GetProtocolConfigClientName(),

cmdline->HasSwitch(::switches::kDisableBackgroundNetworking),

- google_apis::GetAPIKey(), SafeBrowsingProtocolManagerHelper::Version());

+ google_apis::GetAPIKey(), ProtocolManagerHelper::Version());

}

std::string SafeBrowsingService::GetProtocolConfigClientName() const {