MacViews: Select all text on right clicking an unfocused text view.

ui/views/controls/label.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 491 matching lines @@
     render_text->set_focused(false);
     SchedulePaint();
   }
   View::OnBlur();
 }
 
 bool Label::OnMousePressed(const ui::MouseEvent& event) {
   if (!GetRenderTextForSelectionController())
     return false;
 
+  const bool has_focus = HasFocus();

[tapted, 2017/01/25 09:11:16]

optional: maybe had_focus?

[karandeepb, 2017/01/25 10:43:55]

Done.

+
   // RequestFocus() won't work when the label has FocusBehavior::NEVER. Hence
   // explicitly set the focused view.
   // TODO(karandeepb): If a widget with a label having FocusBehavior::NEVER as
   // the currently focused view (due to selection) was to lose focus, focus
   // won't be restored to the label (and hence a text selection won't be drawn)
   // when the widget gets focus again. Fix this.
   // Tracked in https://crbug.com/630365.
   if ((event.IsOnlyLeftMouseButton() || event.IsOnlyRightMouseButton()) &&
-      GetFocusManager()) {
+      GetFocusManager() && !has_focus) {
     GetFocusManager()->SetFocusedView(this);
   }
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
-  if (event.IsOnlyMiddleMouseButton() && GetFocusManager())
+  if (event.IsOnlyMiddleMouseButton() && GetFocusManager() && !has_focus)
     GetFocusManager()->SetFocusedView(this);
 #endif
 
-  return selection_controller_->OnMousePressed(event, false);
+  return selection_controller_->OnMousePressed(
+      event, false, has_focus ? SelectionController::FOCUSED
+                              : SelectionController::UNFOCUSED);
 }
 
 bool Label::OnMouseDragged(const ui::MouseEvent& event) {
   if (!GetRenderTextForSelectionController())
     return false;
 
   return selection_controller_->OnMouseDragged(event);
 }
 
 void Label::OnMouseReleased(const ui::MouseEvent& event) {
@@ skipping 474 matching lines @@
       .WriteText(GetSelectedText());
 }
 
 void Label::BuildContextMenuContents() {
   context_menu_contents_.AddItemWithStringId(IDS_APP_COPY, IDS_APP_COPY);
   context_menu_contents_.AddItemWithStringId(IDS_APP_SELECT_ALL,
                                              IDS_APP_SELECT_ALL);
 }
 
 }  // namespace views