MacViews: Select all text on right clicking an unfocused text view.

ui/views/selection_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/selection_controller.h"
 
 #include <algorithm>
 
 #include "ui/events/event.h"
 #include "ui/gfx/render_text.h"
 #include "ui/views/metrics.h"
 #include "ui/views/selection_controller_delegate.h"
 #include "ui/views/style/platform_style.h"
 #include "ui/views/view.h"
 
 namespace views {
 
 SelectionController::SelectionController(SelectionControllerDelegate* delegate)
     : aggregated_clicks_(0),
       delegate_(delegate),
       handles_selection_clipboard_(false) {
 // On Linux, update the selection clipboard on a text selection.
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   set_handles_selection_clipboard(true);
 #endif
 
   DCHECK(delegate);
 }
 
-bool SelectionController::OnMousePressed(const ui::MouseEvent& event,
-                                         bool handled) {
+bool SelectionController::OnMousePressed(
+    const ui::MouseEvent& event,
+    bool handled,
+    InitialFocusStateOnMousePress initial_focus_state) {
   gfx::RenderText* render_text = GetRenderText();
   DCHECK(render_text);
 
   TrackMouseClicks(event);
   if (handled)
     return true;
 
   if (event.IsOnlyLeftMouseButton()) {
     if (delegate_->SupportsDrag())
       delegate_->SetTextBeingDragged(false);
@@ skipping 12 matching lines @@
           delegate_->OnAfterPointerAction(false, selection_changed);
         }
         break;
       case 1:
         // Select the word at the click location on a double click.
         SelectWord(event.location());
         double_click_word_ = render_text->selection();
         break;
       case 2:
         // Select all the text on a triple click.
-        delegate_->OnBeforePointerAction();
-        render_text->SelectAll(false);
-        delegate_->OnAfterPointerAction(false, true);
+        SelectAll();
         break;
       default:
         NOTREACHED();
     }
   }
 
-  // TODO(crbug.com/676296): Right clicking an unfocused text view should select
-  // all its text on Mac.
-  const bool select_word_on_right_click =
-      event.IsOnlyRightMouseButton() &&
-      PlatformStyle::kSelectWordOnRightClick &&
-      !render_text->IsPointInSelection(event.location());
-  if (select_word_on_right_click)
-    SelectWord(event.location());
+  if (event.IsOnlyRightMouseButton()) {
+    if (PlatformStyle::kSelectAllOnRightClickWhenUnfocused &&
+        initial_focus_state == InitialFocusStateOnMousePress::UNFOCUSED) {
+      SelectAll();
+    } else if (PlatformStyle::kSelectWordOnRightClick &&
+               !render_text->IsPointInSelection(event.location())) {
+      SelectWord(event.location());
+    }
+  }
 
   if (handles_selection_clipboard_ && event.IsOnlyMiddleMouseButton()) {
     if (render_text->IsPointInSelection(event.location())) {
       delegate_->OnBeforePointerAction();
       render_text->ClearSelection();
       delegate_->UpdateSelectionClipboard();
       delegate_->OnAfterPointerAction(false, true);
     } else if (!delegate_->IsReadOnly()) {
       delegate_->OnBeforePointerAction();
       const bool selection_changed =
@@ skipping 88 matching lines @@
 
 void SelectionController::SelectWord(const gfx::Point& point) {
   gfx::RenderText* render_text = GetRenderText();
   DCHECK(render_text);
   delegate_->OnBeforePointerAction();
   render_text->MoveCursorTo(point, false);
   render_text->SelectWord();
   delegate_->OnAfterPointerAction(false, true);
 }
 
+void SelectionController::SelectAll() {
+  gfx::RenderText* render_text = GetRenderText();
+  DCHECK(render_text);
+  delegate_->OnBeforePointerAction();
+  render_text->SelectAll(false);
+  delegate_->OnAfterPointerAction(false, true);
+}
+
 gfx::RenderText* SelectionController::GetRenderText() {
   return delegate_->GetRenderTextForSelectionController();
 }
 
 void SelectionController::SelectThroughLastDragLocation() {
   gfx::RenderText* render_text = GetRenderText();
   DCHECK(render_text);
 
   delegate_->OnBeforePointerAction();
 
   render_text->MoveCursorTo(last_drag_location_, true);
 
   if (aggregated_clicks_ == 1) {
     render_text->SelectWord();
     // Expand the selection so the initially selected word remains selected.
     gfx::Range selection = render_text->selection();
     const size_t min =
         std::min(selection.GetMin(), double_click_word_.GetMin());
     const size_t max =
         std::max(selection.GetMax(), double_click_word_.GetMax());
     const bool reversed = selection.is_reversed();
     selection.set_start(reversed ? max : min);
     selection.set_end(reversed ? min : max);
     render_text->SelectRange(selection);
   }
   delegate_->OnAfterPointerAction(false, true);
 }
 
 }  // namespace views