Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: src/debug/debug.cc

Issue 2650943011: [debug] remove StepFrame (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 31949bb5530b02743966d0e55379932f14719933..63389868316ce1b0cca5a12bb067516daa2d5142 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -561,9 +561,6 @@ void Debug::Break(JavaScriptFrame* frame) {
summary.SourceStatementPosition();
break;
}
- case StepFrame:
- step_break = current_fp != last_fp;
- break;
}
// Clear all current stepping setup.
@@ -1082,12 +1079,6 @@ void Debug::PrepareStep(StepAction step_action) {
// TODO(clemensh): Implement stepping from JS into WASM.
FloodWithOneShot(function);
break;
- case StepFrame:
- // TODO(clemensh): Implement stepping from JS into WASM or vice versa.
- // No point in setting one-shot breaks at places where we are not about
- // to leave the current frame.
- FloodWithOneShot(function, CALLS_AND_RETURNS);
kozy 2017/01/25 20:21:05 We could remove CALLS_AND_RETURNS as well. But as
- break;
}
}
@@ -2153,9 +2144,8 @@ void Debug::UpdateState() {
}
void Debug::UpdateHookOnFunctionCall() {
- STATIC_ASSERT(StepFrame > StepIn);
- STATIC_ASSERT(LastStepAction == StepFrame);
- hook_on_function_call_ = thread_local_.last_step_action_ >= StepIn ||
+ STATIC_ASSERT(LastStepAction == StepIn);
+ hook_on_function_call_ = thread_local_.last_step_action_ == StepIn ||
isolate_->needs_side_effect_check();
}
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698