Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: gin/v8_platform_unittest.cc

Issue 2650943008: [gin] Fire observer after added when recording is in progress. (Closed)
Patch Set: update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/v8_platform.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "gin/public/v8_platform.h"
6
7 #include "base/trace_event/trace_event.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9
10 class TestTraceStateObserver
11 : public NON_EXPORTED_BASE(v8::Platform::TraceStateObserver) {
12 public:
13 void OnTraceEnabled() final { ++enabled_; }
14 void OnTraceDisabled() final { ++disabled_; }
15 int Enabled() { return enabled_; }
16 int Disabled() { return disabled_; }
17
18 private:
19 int enabled_ = 0;
20 int disabled_ = 0;
21 };
22
23 namespace gin {
24
25 TEST(V8PlatformTest, TraceStateObserverAPI) {
26 TestTraceStateObserver* test_observer = new TestTraceStateObserver();
27 ASSERT_EQ(0, test_observer->Enabled());
28 ASSERT_EQ(0, test_observer->Disabled());
29
30 V8Platform::Get()->AddTraceStateObserver(test_observer);
31 base::trace_event::TraceLog::GetInstance()->SetEnabled(
32 base::trace_event::TraceConfig("*", ""),
33 base::trace_event::TraceLog::RECORDING_MODE);
34 ASSERT_EQ(1, test_observer->Enabled());
35 ASSERT_EQ(0, test_observer->Disabled());
36 base::trace_event::TraceLog::GetInstance()->SetDisabled();
37 ASSERT_EQ(1, test_observer->Enabled());
38 ASSERT_EQ(1, test_observer->Disabled());
39
40 V8Platform::Get()->RemoveTraceStateObserver(test_observer);
41 base::trace_event::TraceLog::GetInstance()->SetEnabled(
42 base::trace_event::TraceConfig("*", ""),
43 base::trace_event::TraceLog::RECORDING_MODE);
44 base::trace_event::TraceLog::GetInstance()->SetDisabled();
45 ASSERT_EQ(1, test_observer->Enabled());
46 ASSERT_EQ(1, test_observer->Disabled());
47 }
48
49 TEST(V8PlatformTest, TraceStateObserverFired) {
50 TestTraceStateObserver* test_observer = new TestTraceStateObserver();
51 ASSERT_EQ(0, test_observer->Enabled());
52 ASSERT_EQ(0, test_observer->Disabled());
53
54 base::trace_event::TraceLog::GetInstance()->SetEnabled(
55 base::trace_event::TraceConfig("*", ""),
56 base::trace_event::TraceLog::RECORDING_MODE);
57 V8Platform::Get()->AddTraceStateObserver(test_observer);
58 ASSERT_EQ(1, test_observer->Enabled());
59 ASSERT_EQ(0, test_observer->Disabled());
60 }
61
62 } // namespace gin
OLDNEW
« no previous file with comments | « gin/v8_platform.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698