Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2650943006: Allow summary type inference to infer a type of `void`. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow summary type inference to infer a type of `void`. This makes summary type inference match a previously-untested behavior of non-summary type inference. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9a24350ab18ceb1488a2694ac67fe65f3f57cb80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-24 17:08:59 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-24 17:10:45 UTC) #3
Paul Berry
3 years, 11 months ago (2017-01-24 17:42:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a24350ab18ceb1488a2694ac67fe65f3f57cb80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698