SPDY: Add a bunch of CHECKs into SpdyWriteQueue to detect re-entrancy.

SPDY: Add a bunch of CHECKs into SpdyWriteQueue to detect re-entrancy.

Specifically only look for re-entrancy that shrinks the queue. We know
that other types of iterator invalidation happens due to growing the
queue, but that doesn't match the symptom we're seeing.

BUG=369539
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267984

[Johnny, 2014-05-02 21:16:31]

lgtm % comment

https://codereview.chromium.org/265093004/diff/1/net/spdy/spdy_write_queue.cc
File net/spdy/spdy_write_queue.cc (right):

https://codereview.chromium.org/265093004/diff/1/net/spdy/spdy_write_queue.cc...
net/spdy/spdy_write_queue.cc:136: CHECK(!removing_writes_);
Think we should have removing_writes_ = true here.

[willchan no longer on Chromium, 2014-05-02 21:21:24]

Good call, done.

https://codereview.chromium.org/265093004/diff/1/net/spdy/spdy_write_queue.cc
File net/spdy/spdy_write_queue.cc (right):

https://codereview.chromium.org/265093004/diff/1/net/spdy/spdy_write_queue.cc...
net/spdy/spdy_write_queue.cc:136: CHECK(!removing_writes_);
On 2014/05/02 21:16:32, Johnny wrote:
> Think we should have removing_writes_ = true here.

Done.

[willchan no longer on Chromium, 2014-05-02 21:29:27]

The CQ bit was checked by willchan@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:32:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/willchan@chromium.org/265093004/20001

[commit-bot: I haz the power, 2014-05-02 21:32:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:32:24]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ryan Hamilton, 2014-05-02 21:53:39]

lgtm

[willchan no longer on Chromium, 2014-05-02 21:53:55]

The CQ bit was checked by willchan@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:55:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/willchan@chromium.org/265093004/20001

[commit-bot: I haz the power, 2014-05-03 00:13:58]

Change committed as 267984