chrome/test/BUILD.gn - Issue 2650923002: Fixes ungraceful handling of destroyed GlobalError GlobalErrorBubbleView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 2650923002: Fixes ungraceful handling of destroyed GlobalError GlobalErrorBubbleView. (Closed)

Patch Set: Addresses Wez's and sky's comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 32b170e9dd73dfdb90eb359d350cd8b7c89c356b..464735a8c52a3347ed1ba7475cd0a433a99dfcf4 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -3354,6 +3354,7 @@ test("unit_tests") {

"../browser/ui/sync/sync_promo_ui_unittest.cc",

"../browser/ui/tests/ui_gfx_image_unittest.cc",

"../browser/ui/tests/ui_gfx_image_unittest.mm",

+ "../browser/ui/views/global_error_bubble_view_unittest.cc",

"../browser/ui/website_settings/mock_permission_prompt.cc",

"../browser/ui/website_settings/mock_permission_prompt.h",

"../browser/ui/website_settings/mock_permission_prompt_factory.cc",