chrome/browser/ui/global_error/global_error.h - Issue 2650923002: Fixes ungraceful handling of destroyed GlobalError GlobalErrorBubbleView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/global_error/global_error.h

Issue 2650923002: Fixes ungraceful handling of destroyed GlobalError GlobalErrorBubbleView. (Closed)

Patch Set: Use fake instead of mock button listener Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/global_error/global_error.h

diff --git a/chrome/browser/ui/global_error/global_error.h b/chrome/browser/ui/global_error/global_error.h

index fbfee28d6a382e1170c338246c1f1f6ae8d2d2a7..21b779923017f5a4480a5ed2d64a65310cee3820 100644

--- a/chrome/browser/ui/global_error/global_error.h

+++ b/chrome/browser/ui/global_error/global_error.h

@@ -87,7 +87,7 @@ class GlobalErrorWithStandardBubble

virtual base::string16 GetBubbleViewCancelButtonLabel() = 0;

// Called when the bubble view is closed. |browser| is the Browser that the

// bubble view was shown on.

- void BubbleViewDidClose(Browser* browser);

+ virtual void BubbleViewDidClose(Browser* browser);

// Notifies subclasses that the bubble view is closed. |browser| is the

// Browser that the bubble view was shown on.

virtual void OnBubbleViewDidClose(Browser* browser) = 0;

« no previous file with comments | « no previous file | chrome/browser/ui/views/global_error_bubble_view.cc » ('j') | no next file with comments »