Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 2650903003: Revert of [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.h
diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h
index 5ebaa0ca872a9711b6addf920125eb3ad28db1a4..fdb1ac59ae589c4e99aa1d49dbddad9b305024f9 100644
--- a/content/browser/devtools/protocol/page_handler.h
+++ b/content/browser/devtools/protocol/page_handler.h
@@ -19,10 +19,6 @@
#include "content/public/browser/readback_types.h"
class SkBitmap;
-
-namespace gfx {
-class Image;
-} // namespace gfx
namespace content {
@@ -69,8 +65,6 @@
Response NavigateToHistoryEntry(int entry_id) override;
void CaptureScreenshot(
- Maybe<std::string> format,
- Maybe<int> quality,
std::unique_ptr<CaptureScreenshotCallback> callback) override;
Response StartScreencast(Maybe<std::string> format,
Maybe<int> quality,
@@ -97,8 +91,6 @@
void NavigationRequested(const PageNavigationThrottle* throttle);
private:
- enum EncodingFormat { PNG, JPEG };
-
WebContentsImpl* GetWebContents();
void NotifyScreencastVisibility(bool visible);
void InnerSwapCompositorFrame();
@@ -109,10 +101,10 @@
const base::Time& timestamp,
const std::string& data);
- void ScreenshotCaptured(std::unique_ptr<CaptureScreenshotCallback> callback,
- const std::string& format,
- int quality,
- const gfx::Image& image);
+ void ScreenshotCaptured(
+ std::unique_ptr<CaptureScreenshotCallback> callback,
+ const unsigned char* png_data,
+ size_t png_size);
void OnColorPicked(int r, int g, int b, int a);
« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | content/browser/devtools/protocol/page_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698