third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp - Issue 2650903002: Ignore scroll node when checking whether a chunk can merge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp

Issue 2650903002: Ignore scroll node when checking whether a chunk can merge. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp

index cc7854111ea84efcb9a12934c3138dadf4c2f528..eed1b3e6df7fb0d8c7c4b4ccc680b004d7377214 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp

@@ -87,6 +87,8 @@ FloatRect GeometryMapper::localToAncestorVisualRectInternal(

const PropertyTreeState& localState,

const PropertyTreeState& ancestorState,

bool& success) {

+ // TODO(wkorman): Consider using PropertyTreeState::equivalentGeometry() so as

+ // to ignore scroll node diff for comparison purposes.

if (localState == ancestorState) {

success = true;

return rect;