Reland: [Compiler] Enable handles created during parsing and scope analysis to be deferred.

test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler-dispatcher/compiler-dispatcher.h"
 
 #include "include/v8-platform.h"
 #include "src/base/platform/semaphore.h"
 #include "src/compiler-dispatcher/compiler-dispatcher-job.h"
 #include "src/compiler-dispatcher/compiler-dispatcher-tracer.h"
 #include "src/compiler.h"
 #include "src/flags.h"
 #include "src/handles.h"
 #include "src/objects-inl.h"
 #include "src/parsing/parse-info.h"
+#include "src/parsing/parsing.h"
 #include "src/v8.h"
 #include "test/unittests/compiler-dispatcher/compiler-dispatcher-helper.h"
 #include "test/unittests/test-utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace v8 {
 namespace internal {
 
 class CompilerDispatcherTest : public TestWithContext {
  public:
@@ skipping 783 matching lines @@
   CompilerDispatcher dispatcher(i_isolate(), &platform, FLAG_stack_size);
 
   const char script[] =
       "function g() { var y = 1; function f17(x) { return x * y }; return f17; "
       "} g();";
   Handle<JSFunction> f = Handle<JSFunction>::cast(RunJS(isolate(), script));
   Handle<SharedFunctionInfo> shared(f->shared(), i_isolate());
 
   ParseInfo parse_info(shared);
   ASSERT_TRUE(Compiler::ParseAndAnalyze(&parse_info));
+  std::shared_ptr<DeferredHandles> handles;
 
   ASSERT_FALSE(dispatcher.IsEnqueued(shared));
-  ASSERT_TRUE(dispatcher.Enqueue(shared, parse_info.literal()));
+  ASSERT_TRUE(dispatcher.Enqueue(shared, parse_info.literal(),
+                                 parse_info.zone_shared(), handles, handles));
   ASSERT_TRUE(dispatcher.IsEnqueued(shared));
 
   ASSERT_TRUE(dispatcher.jobs_.begin()->second->status() ==
               CompileJobStatus::kAnalyzed);
 
   ASSERT_TRUE(platform.IdleTaskPending());
   platform.ClearIdleTask();
   ASSERT_FALSE(platform.BackgroundTasksPending());
 }
 
 TEST_F(CompilerDispatcherTest, EnqueueAndStepParsed) {
   MockPlatform platform;
   CompilerDispatcher dispatcher(i_isolate(), &platform, FLAG_stack_size);
 
   const char script[] =
       "function g() { var y = 1; function f18(x) { return x * y }; return f18; "
       "} g();";
   Handle<JSFunction> f = Handle<JSFunction>::cast(RunJS(isolate(), script));
   Handle<SharedFunctionInfo> shared(f->shared(), i_isolate());
 
   ParseInfo parse_info(shared);
   ASSERT_TRUE(Compiler::ParseAndAnalyze(&parse_info));
+  std::shared_ptr<DeferredHandles> handles;
 
   ASSERT_FALSE(dispatcher.IsEnqueued(shared));
-  ASSERT_TRUE(dispatcher.EnqueueAndStep(shared, parse_info.literal()));
+  ASSERT_TRUE(dispatcher.EnqueueAndStep(shared, parse_info.literal(),
+                                        parse_info.zone_shared(), handles,
+                                        handles));
   ASSERT_TRUE(dispatcher.IsEnqueued(shared));
 
   ASSERT_TRUE(dispatcher.jobs_.begin()->second->status() ==
               CompileJobStatus::kReadyToCompile);
 
   ASSERT_TRUE(platform.IdleTaskPending());
   ASSERT_TRUE(platform.BackgroundTasksPending());
   platform.ClearIdleTask();
   platform.ClearBackgroundTasks();
 }
@@ skipping 13 matching lines @@
       "} g();";
   Handle<JSFunction> f2 = Handle<JSFunction>::cast(RunJS(isolate(), script2));
   Handle<SharedFunctionInfo> shared2(f2->shared(), i_isolate());
 
   ASSERT_FALSE(shared1->is_compiled());
   ASSERT_FALSE(shared2->is_compiled());
 
   // Enqueue shared1 as already parsed.
   ParseInfo parse_info(shared1);
   ASSERT_TRUE(Compiler::ParseAndAnalyze(&parse_info));
-  ASSERT_TRUE(dispatcher.Enqueue(shared1, parse_info.literal()));
+  std::shared_ptr<DeferredHandles> handles;
+  ASSERT_TRUE(dispatcher.Enqueue(shared1, parse_info.literal(),
+                                 parse_info.zone_shared(), handles, handles));
 
   // Enqueue shared2 for parsing and compiling
   ASSERT_TRUE(dispatcher.Enqueue(shared2));
 
   ASSERT_TRUE(dispatcher.FinishAllNow());
 
   // Finishing removes the SFI from the queue.
   ASSERT_FALSE(dispatcher.IsEnqueued(shared1));
   ASSERT_FALSE(dispatcher.IsEnqueued(shared2));
   ASSERT_TRUE(shared1->is_compiled());
   ASSERT_TRUE(shared2->is_compiled());
   ASSERT_TRUE(platform.IdleTaskPending());
   platform.ClearIdleTask();
 }
 
+TEST_F(CompilerDispatcherTest, CompileParsedOutOfScope) {
+  MockPlatform platform;
+  CompilerDispatcher dispatcher(i_isolate(), &platform, FLAG_stack_size);
+
+  const char script[] =
+      "function g() { var y = 1; function f20(x) { return x + y }; return f20; "
+      "} g();";
+  Handle<JSFunction> f = Handle<JSFunction>::cast(RunJS(isolate(), script));
+  Handle<SharedFunctionInfo> shared(f->shared(), i_isolate());
+
+  {
+    HandleScope scope(i_isolate());  // Create handles scope for parsing.
+
+    ASSERT_FALSE(shared->is_compiled());
+    ParseInfo parse_info(shared);
+
+    ASSERT_TRUE(parsing::ParseAny(&parse_info));
+    DeferredHandleScope handles_scope(i_isolate());
+    { ASSERT_TRUE(Compiler::Analyze(&parse_info)); }
+    std::shared_ptr<DeferredHandles> compilation_handles(
+        handles_scope.Detach());
+
+    ASSERT_FALSE(platform.IdleTaskPending());
+    ASSERT_TRUE(dispatcher.Enqueue(
+        shared, parse_info.literal(), parse_info.zone_shared(),
+        parse_info.deferred_handles(), compilation_handles));
+    ASSERT_TRUE(platform.IdleTaskPending());
+  }
+  // Exit the handles scope and destroy ParseInfo before running the idle task.
+
+  // Since time doesn't progress on the MockPlatform, this is enough idle time
+  // to finish compiling the function.
+  platform.RunIdleTask(1000.0, 0.0);
+
+  ASSERT_FALSE(dispatcher.IsEnqueued(shared));
+  ASSERT_TRUE(shared->is_compiled());
+}
+
 }  // namespace internal
 }  // namespace v8