Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: base/trace_event/process_memory_dump_unittest.cc

Issue 2650863003: [tracing] Switch to new heap dump format. (Closed)
Patch Set: Add 'version' field. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/process_memory_dump_unittest.cc
diff --git a/base/trace_event/process_memory_dump_unittest.cc b/base/trace_event/process_memory_dump_unittest.cc
index 571774a10ca2224e469e447902be2e0b5618953b..110fa8d58a1a6e45acabf7e35a1d29ec4290a2bd 100644
--- a/base/trace_event/process_memory_dump_unittest.cc
+++ b/base/trace_event/process_memory_dump_unittest.cc
@@ -24,10 +24,12 @@ const char* const kTestDumpNameWhitelist[] = {
"Whitelisted/TestName", "Whitelisted/TestName_0x?",
"Whitelisted/0x?/TestName", nullptr};
+#if 0
TracedValue* GetHeapDump(const ProcessMemoryDump& pmd, const char* name) {
auto it = pmd.heap_dumps().find(name);
return it == pmd.heap_dumps().end() ? nullptr : it->second.get();
}
+#endif
} // namespace
@@ -88,6 +90,7 @@ TEST(ProcessMemoryDumpTest, Clear) {
pmd1.reset();
}
+#if 0
TEST(ProcessMemoryDumpTest, TakeAllDumpsFrom) {
std::unique_ptr<TracedValue> traced_value(new TracedValue);
hash_map<AllocationContext, AllocationMetrics> metrics_by_context;
@@ -163,6 +166,7 @@ TEST(ProcessMemoryDumpTest, TakeAllDumpsFrom) {
pmd1.reset();
}
+#endif
TEST(ProcessMemoryDumpTest, Suballocations) {
std::unique_ptr<ProcessMemoryDump> pmd(

Powered by Google App Engine
This is Rietveld 408576698