Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: services/ui/ws/window_tree.cc

Issue 2650833002: Set focusibility correctly when initializing a window in mus+ash. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/window_tree.cc
diff --git a/services/ui/ws/window_tree.cc b/services/ui/ws/window_tree.cc
index 77fd68d27593e422e7f7bb13f46894584bdf0988..46b2c4d785ecc27bf3e2ff14a24ab05eff52e474 100644
--- a/services/ui/ws/window_tree.cc
+++ b/services/ui/ws/window_tree.cc
@@ -1547,7 +1547,7 @@ void WindowTree::SetCanFocus(Id transport_window_id, bool can_focus) {
GetWindowByClientId(ClientWindowId(transport_window_id));
// TODO(sky): there should be an else case (it shouldn't route to wm and
// policy allows, then set_can_focus).
- if (window && ShouldRouteToWindowManager(window))
+ if (window && access_policy_->CanSetFocus(window))
sky 2017/01/23 21:28:29 This needs to go to the window manager too, otherw
Hadi 2017/01/24 18:42:32 Done.
window->set_can_focus(can_focus);
sadrul 2017/01/24 17:34:49 if (!window) return; if (ShouldRouteToWndowMana
sadrul 2017/01/24 17:35:23 Whoops, sorry. Please ignore this comment.
}

Powered by Google App Engine
This is Rietveld 408576698