Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: services/ui/public/interfaces/window_manager.mojom

Issue 2650833002: Set focusibility correctly when initializing a window in mus+ash. (Closed)
Patch Set: addressed feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/demo/mus_demo.cc ('k') | services/ui/test_wm/test_wm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module ui.mojom; 5 module ui.mojom;
6 6
7 import "services/ui/public/interfaces/cursor.mojom"; 7 import "services/ui/public/interfaces/cursor.mojom";
8 import "services/ui/public/interfaces/event_matcher.mojom"; 8 import "services/ui/public/interfaces/event_matcher.mojom";
9 import "services/ui/public/interfaces/window_manager_constants.mojom"; 9 import "services/ui/public/interfaces/window_manager_constants.mojom";
10 import "services/ui/public/interfaces/window_tree_constants.mojom"; 10 import "services/ui/public/interfaces/window_tree_constants.mojom";
(...skipping 17 matching lines...) Expand all
28 // . Long lived properties. These properties may be changed at any time and 28 // . Long lived properties. These properties may be changed at any time and
29 // are mapped to aura::Window properties. aura::PropertyConverter defines 29 // are mapped to aura::Window properties. aura::PropertyConverter defines
30 // the mapping between the property defined here and the corresonding 30 // the mapping between the property defined here and the corresonding
31 // aura property. For properties defined in PropertyConverter any change to 31 // aura property. For properties defined in PropertyConverter any change to
32 // to the aura property is mapped to the property defined here and sent to 32 // to the aura property is mapped to the property defined here and sent to
33 // all clients that know about the window (which is generally just the owner 33 // all clients that know about the window (which is generally just the owner
34 // and the window-manager). 34 // and the window-manager).
35 35
36 // Properties used only during creation time. -------------------------------- 36 // Properties used only during creation time. --------------------------------
37 37
38 // Whether the window should be initially focusable or not. Type: bool.
39 const string kFocusable_InitProperty = "init:focusable";
40
38 // Initial bounds to create the window at. If empty the WindowManager decides 41 // Initial bounds to create the window at. If empty the WindowManager decides
39 // the initial bounds. Type: gfx::Rect. 42 // the initial bounds. Type: gfx::Rect.
40 const string kBounds_InitProperty = "init:bounds"; 43 const string kBounds_InitProperty = "init:bounds";
41 44
42 // The window manager will place the window in this container when the window 45 // The window manager will place the window in this container when the window
43 // is created. If not set a container is selected based on the window type. 46 // is created. If not set a container is selected based on the window type.
44 // Type: int32_t. 47 // Type: int32_t.
45 const string kContainerId_InitProperty = "init:container_id"; 48 const string kContainerId_InitProperty = "init:container_id";
46 49
47 // Disables the window manager from handling immersive fullscreen for the 50 // Disables the window manager from handling immersive fullscreen for the
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 WmDisplayModified(display.mojom.Display display); 165 WmDisplayModified(display.mojom.Display display);
163 166
164 // When the WindowManager completes a request it must call back to 167 // When the WindowManager completes a request it must call back to
165 // WindowManagerClient::WmResponse(). 168 // WindowManagerClient::WmResponse().
166 WmSetBounds(uint32 change_id, uint32 window_id, gfx.mojom.Rect bounds); 169 WmSetBounds(uint32 change_id, uint32 window_id, gfx.mojom.Rect bounds);
167 WmSetProperty(uint32 change_id, 170 WmSetProperty(uint32 change_id,
168 uint32 window_id, 171 uint32 window_id,
169 string name, 172 string name,
170 array<uint8>? value); 173 array<uint8>? value);
171 174
175 WmSetCanFocus(uint32 window_id, bool can_focus);
176
172 // Asks the WindowManager to create a new window. 177 // Asks the WindowManager to create a new window.
173 // |requesting_client_id| is the id of the client issuing the request. This 178 // |requesting_client_id| is the id of the client issuing the request. This
174 // allows the window manager to track top level windows by client. 179 // allows the window manager to track top level windows by client.
175 WmCreateTopLevelWindow(uint32 change_id, 180 WmCreateTopLevelWindow(uint32 change_id,
176 uint16 requesting_client_id, 181 uint16 requesting_client_id,
177 map<string, array<uint8>> properties); 182 map<string, array<uint8>> properties);
178 183
179 // A WindowTreeClient is considered "janky" by Mus when it stops ACK'ing input 184 // A WindowTreeClient is considered "janky" by Mus when it stops ACK'ing input
180 // events within a reasonable timeframe. When a client enters or exits this 185 // events within a reasonable timeframe. When a client enters or exits this
181 // state, Mus will tell the window manager about it so that the window manager 186 // state, Mus will tell the window manager about it so that the window manager
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 WmSetNonClientCursor(uint32 window_id, Cursor cursor_id); 261 WmSetNonClientCursor(uint32 window_id, Cursor cursor_id);
257 262
258 // Response from WmCreateTopLevelWindow() informing the client of the id for 263 // Response from WmCreateTopLevelWindow() informing the client of the id for
259 // the new window. 264 // the new window.
260 OnWmCreatedTopLevelWindow(uint32 change_id, uint32 window_id); 265 OnWmCreatedTopLevelWindow(uint32 change_id, uint32 window_id);
261 266
262 // See description in WindowManager::OnAccelerator(). |ack_id| is the value 267 // See description in WindowManager::OnAccelerator(). |ack_id| is the value
263 // that was passed to OnAccelerator(). 268 // that was passed to OnAccelerator().
264 OnAcceleratorAck(uint32 ack_id, EventResult event_result); 269 OnAcceleratorAck(uint32 ack_id, EventResult event_result);
265 }; 270 };
OLDNEW
« no previous file with comments | « services/ui/demo/mus_demo.cc ('k') | services/ui/test_wm/test_wm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698