Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2650823007: Allow debugger to stop when reading a static field (Closed)

Created:
3 years, 11 months ago by hausner
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow debugger to stop when reading a static field Add a DebugStepCheck when the right-hand side of an expression is an access to a static field or top-level variable. BUG=#28453 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/197f1411001f47e3504f670ad155230452570c0d

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into bb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/flow_graph_builder.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
3 years, 11 months ago (2017-01-25 18:16:12 UTC) #3
rmacnak
lgtm
3 years, 11 months ago (2017-01-25 22:24:02 UTC) #4
hausner
3 years, 11 months ago (2017-01-25 22:39:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
197f1411001f47e3504f670ad155230452570c0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698