Wire NetLog into the TreeStateTracker

components/certificate_transparency/tree_state_tracker.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/certificate_transparency/tree_state_tracker.h"
 
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
 #include "components/certificate_transparency/log_dns_client.h"
 #include "components/certificate_transparency/single_tree_tracker.h"
@@ skipping 15 matching lines @@
 const size_t kMaxConcurrentDnsQueries = 1;
 }
 
 namespace certificate_transparency {
 
 // Enables or disables auditing Certificate Transparency logs over DNS.
 const base::Feature kCTLogAuditing = {"CertificateTransparencyLogAuditing",
                                       base::FEATURE_DISABLED_BY_DEFAULT};
 
 TreeStateTracker::TreeStateTracker(
-    std::vector<scoped_refptr<const CTLogVerifier>> ct_logs) {
+    std::vector<scoped_refptr<const CTLogVerifier>> ct_logs,
+    net::NetLog* net_log) {
   if (!base::FeatureList::IsEnabled(kCTLogAuditing))
     return;
 
-  // TODO(eranm): Hook up a real NetLog.
-  net::NetLogWithSource net_log;
   std::unique_ptr<net::DnsClient> dns_client =
-      net::DnsClient::CreateClient(net_log.net_log());
-  dns_client_ = base::MakeUnique<LogDnsClient>(std::move(dns_client), net_log,
-                                               kMaxConcurrentDnsQueries);
+      net::DnsClient::CreateClient(net_log);
+  dns_client_ = base::MakeUnique<LogDnsClient>(
+      std::move(dns_client),
+      net::NetLogWithSource::Make(
+          net_log, net::NetLogSourceType::CT_LOG_AUDITOR),

[eroman, 2017/01/25 21:23:08]

An alternate name could be CT_TREE_STATE_TRACKER, up to you.

[Eran Messeri, 2017/01/26 15:08:40]

Done, as it'd be more consistent with the name of the class (but TBH I think the
class is not named particularly well. How about renaming it to CTLogAuditor ?)

[eroman, 2017/01/26 18:20:39]

sgtm

+      kMaxConcurrentDnsQueries);
 
   for (const auto& log : ct_logs) {
     tree_trackers_[log->key_id()].reset(
         new SingleTreeTracker(log, dns_client_.get()));
   }
 }
 
 TreeStateTracker::~TreeStateTracker() {}
 
 void TreeStateTracker::OnSCTVerified(X509Certificate* cert,
@@ skipping 11 matching lines @@
   // Is the STH from a known log? Since STHs can be provided from external
   // sources for logs not yet recognized by this client, return, rather than
   // DCHECK.
   if (it == tree_trackers_.end())
     return;
 
   it->second->NewSTHObserved(sth);
 }
 
 }  // namespace certificate_transparency