Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: pkg/fasta/lib/src/source/outline_builder.dart

Issue 2650803002: Rename events. (Closed)
Patch Set: Address review comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/fasta/lib/src/source/diet_listener.dart ('k') | pkg/fasta/lib/src/source/scope_listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/fasta/lib/src/source/outline_builder.dart
diff --git a/pkg/fasta/lib/src/source/outline_builder.dart b/pkg/fasta/lib/src/source/outline_builder.dart
index 7a51e55bc964d1f6f8dad0d835f0aee3b0cba39a..45beda7a1fe7fdbe43e4e0b15133c985b25f6f31 100644
--- a/pkg/fasta/lib/src/source/outline_builder.dart
+++ b/pkg/fasta/lib/src/source/outline_builder.dart
@@ -203,8 +203,8 @@ class OutlineBuilder extends UnhandledListener {
push(MethodBody.Abstract);
}
- void skippedFunctionBody(Token token) {
- debugEvent("skippedFunctionBody");
+ void handleFunctionBodySkipped(Token token) {
+ debugEvent("handleFunctionBodySkipped");
push(MethodBody.Regular);
}
@@ -297,7 +297,7 @@ class OutlineBuilder extends UnhandledListener {
// Ignored for now.
}
- void handleFunctionTypedFormalParameter(Token token) {
+ void endFunctionTypedFormalParameter(Token token) {
debugEvent("FunctionTypedFormalParameter");
pop(); // Function type parameters.
pop(); // Type variables.
@@ -432,10 +432,9 @@ class OutlineBuilder extends UnhandledListener {
push(MethodBody.RedirectingFactoryBody);
}
- void endInitializer(Token assignmentOperator) {
- debugEvent("Initializer");
- // This is a variable initializer and it's ignored for now. May also be
- // constructor initializer.
+ void endFieldInitializer(Token assignmentOperator) {
+ debugEvent("FieldInitializer");
+ // Ignoring field initializers for now.
}
void endInitializers(int count, Token beginToken, Token endToken) {
« no previous file with comments | « pkg/fasta/lib/src/source/diet_listener.dart ('k') | pkg/fasta/lib/src/source/scope_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698