Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1787)

Issue 2650803002: Rename events. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -51 lines) Patch
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 4 chunks +8 lines, -3 lines 0 comments Download
M pkg/dart_parser/lib/src/listener.dart View 1 7 chunks +33 lines, -13 lines 0 comments Download
M pkg/dart_parser/lib/src/parser.dart View 5 chunks +19 lines, -11 lines 0 comments Download
M pkg/fasta/lib/src/analyzer/ast_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/fasta/lib/src/kernel/body_builder.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/fasta/lib/src/source/diet_listener.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/fasta/lib/src/source/outline_builder.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/fasta/lib/src/source/scope_listener.dart View 8 chunks +20 lines, -0 lines 0 comments Download
M pkg/fasta/lib/src/source/stack_listener.dart View 4 chunks +22 lines, -4 lines 0 comments Download
M pkg/fasta/lib/src/source/unhandled_listener.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ahe
3 years, 11 months ago (2017-01-23 18:42:06 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2650803002/diff/20001/pkg/dart_parser/lib/src/listener.dart File pkg/dart_parser/lib/src/listener.dart (right): https://codereview.chromium.org/2650803002/diff/20001/pkg/dart_parser/lib/src/listener.dart#newcode26 pkg/dart_parser/lib/src/listener.dart:26: /// Events are methods that begin with one ...
3 years, 11 months ago (2017-01-23 18:51:25 UTC) #5
ahe
I've updated the documentation, PTAL. https://codereview.chromium.org/2650803002/diff/20001/pkg/dart_parser/lib/src/listener.dart File pkg/dart_parser/lib/src/listener.dart (right): https://codereview.chromium.org/2650803002/diff/20001/pkg/dart_parser/lib/src/listener.dart#newcode26 pkg/dart_parser/lib/src/listener.dart:26: /// Events are methods ...
3 years, 11 months ago (2017-01-23 19:04:56 UTC) #6
Siggi Cherem (dart-lang)
lgtm, thanks!
3 years, 11 months ago (2017-01-23 19:45:36 UTC) #7
ahe
3 years, 11 months ago (2017-01-24 09:21:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
471652697f4c4060de1904eadc0ab1bc284d1b15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698