[parser]: Skipping inner funcs / initial implemetation of storing scope analysis data from preparse…

src/parsing/preparsed-scope-data.h

+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_PARSING_PREPARSED_SCOPE_DATA_H_
+#define V8_PARSING_PREPARSED_SCOPE_DATA_H_
+
+#include <vector>
+
+#include "src/globals.h"
+
+namespace v8 {
+namespace internal {
+
+class PreParsedScopeData {
+ public:
+  PreParsedScopeData() : current_scope_data_(nullptr) {}
+
+  class ScopeData {

[vogelheim, 2017/01/25 10:00:18]

troll nitpick: V8 style calls objects that open+finish some work in their
con-/de-structors **Scope. Please rename to ScopeDataScope.

[vogelheim, 2017/01/25 10:00:18]

maybe: Have a PreParsedScopeData::AddScope(ScopeType, int, int) method.

Then the ScopeData structure can be a non-public implementation detail of
PreParsedScopeData, and we need one less friend declaration.

If the destructor is important, that method could return an (otherwise opaque)
scope object that calls a close method of sorts.

[marja, 2017/01/25 10:21:26]

Used this opportunity to rename it to ScopeScope which was the original name.

[marja, 2017/01/25 10:21:26]

Acknowledged.

Offline discussion: Won't do anything for now; let's see how the next stage
looks like. Variable adding functions will be in ScopeScope.

+   public:
+    ScopeData(PreParsedScopeData* data, ScopeType scope_type,
+              int start_position, int end_position);
+    ~ScopeData();
+
+    // TODO(marja): The functions for adding information about local variables
+    // will appar here.

[vogelheim, 2017/01/25 10:00:18]

nitpick: appar -> appear.

[marja, 2017/01/25 10:21:26]

Done.

+
+   private:
+    PreParsedScopeData* data_;
+    size_t index_in_data_;
+    ScopeData* previous_scope_;
+
+    int inner_scope_count_;
+    int variable_count_;
+    DISALLOW_COPY_AND_ASSIGN(ScopeData);
+  };
+
+ private:
+  friend class ScopeData;
+  friend class ScopeTestHelper;
+
+  // TODO(marja): Make the backing store more efficient once we know exactly
+  // what data is needed.
+  std::vector<int> backing_store_;
+  ScopeData* current_scope_data_;
+
+  DISALLOW_COPY_AND_ASSIGN(PreParsedScopeData);
+};
+
+}  // namespace internal
+}  // namespace v8
+
+#endif  // PREPARSED_SCOPE_DATA_H_

[vogelheim, 2017/01/25 10:00:18]

nitpick: // V8_PARSING_PREPARSED_SCOPE_DATA_H_

[marja, 2017/01/25 10:21:26]

Done.