Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2650693004: VM: Fix memory leaks during isolate spawning (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix memory leaks during isolate spawning Fixes #28351 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d7e884b05f762f8d5016eb8a5444471b647e213a

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebased & Renamed TakeBuffer -> StealBuffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -35 lines) Patch
M runtime/lib/isolate.cc View 3 chunks +40 lines, -12 lines 0 comments Download
M runtime/vm/datastream.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.h View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 1 4 chunks +8 lines, -11 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 chunks +33 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
https://codereview.chromium.org/2650693004/diff/1/runtime/lib/isolate.cc File runtime/lib/isolate.cc (left): https://codereview.chromium.org/2650693004/diff/1/runtime/lib/isolate.cc#oldcode245 runtime/lib/isolate.cc:245: packageConfig.IsNull() ? NULL : String2UTF8(packageConfig); These two allocated strings ...
3 years, 11 months ago (2017-01-23 19:14:55 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2650693004/diff/1/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/2650693004/diff/1/runtime/vm/snapshot.h#newcode991 runtime/vm/snapshot.h:991: void TakeBuffer(uint8_t** out_data, intptr_t* out_length) { Similar existing ...
3 years, 11 months ago (2017-01-24 03:54:53 UTC) #3
kustermann
Committed patchset #2 (id:20001) manually as d7e884b05f762f8d5016eb8a5444471b647e213a (presubmit successful).
3 years, 11 months ago (2017-01-24 08:59:22 UTC) #5
kustermann
3 years, 11 months ago (2017-01-24 09:02:00 UTC) #6
Message was sent while issue was closed. 
Thank you.

https://codereview.chromium.org/2650693004/diff/1/runtime/vm/snapshot.h
File runtime/vm/snapshot.h (right):

https://codereview.chromium.org/2650693004/diff/1/runtime/vm/snapshot.h#newco...
runtime/vm/snapshot.h:991: void TakeBuffer(uint8_t** out_data, intptr_t*
out_length) {
On 2017/01/24 03:54:53, rmacnak wrote:
> Similar existing methods in the VM are called StealBuffer.

Done.

Powered by Google App Engine
This is Rietveld 408576698