Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2650693002: Add changelog to dart spec file. (Closed)

Created:
3 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, Kevin Millikin (Google)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Typos #

Total comments: 4

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M docs/language/dartLangSpec.tex View 1 2 1 chunk +48 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-23 11:02:00 UTC) #2
Kevin Millikin (Google)
YES! https://codereview.chromium.org/2650693002/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2650693002/diff/1/docs/language/dartLangSpec.tex#newcode48 docs/language/dartLangSpec.tex:48: % if the parmameters are non-constant. parmameters => ...
3 years, 11 months ago (2017-01-23 11:05:22 UTC) #4
floitsch
LGTM!
3 years, 11 months ago (2017-01-23 12:16:28 UTC) #5
eernst
LGTM! https://codereview.chromium.org/2650693002/diff/20001/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2650693002/diff/20001/docs/language/dartLangSpec.tex#newcode51 docs/language/dartLangSpec.tex:51: % - Specify null-aware operators for static methods. ...
3 years, 11 months ago (2017-01-23 12:31:06 UTC) #6
Lasse Reichstein Nielsen
Committed patchset #3 (id:40001) manually as c77a4a92b244e72272b01c6b4e590518f3bf62ac (presubmit successful).
3 years, 11 months ago (2017-01-23 13:00:34 UTC) #8
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-23 13:29:28 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/2650693002/diff/20001/docs/language/dartLangS...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2650693002/diff/20001/docs/language/dartLangS...
docs/language/dartLangSpec.tex:51: % - Specify null-aware operators for static
methods.
On 2017/01/23 12:31:06, eernst wrote:
> This would be ECMA-408, 4th edition (even though that document says '4th
edition
> draft' on page 1, right after the front matter ;-). It makes sense to mention
> the latest ECMA document explicitly, because that's the one that people will
> find if they search for it.

Done.

https://codereview.chromium.org/2650693002/diff/20001/docs/language/dartLangS...
docs/language/dartLangSpec.tex:63: % - Ecma TC52 - 3rd Edition of the Dart
specification.
On 2017/01/23 12:31:06, eernst wrote:
> I believe the most direct reference would be ECMA-408, 3rd edition. TC52 is
the
> 'technical committee' and a couple of experiments seem to confirm that the
> document can be Google'd directly from 'ECMA-408' whereas 'Ecma TC52' goes to
a
> description of the committee from where it requires at least some extra clicks
> to find the document (I can't see any direct links).

Done.

Powered by Google App Engine
This is Rietveld 408576698