Issue 26506003: Setting host without port should keep old port

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26506003: Setting host without port should keep old port (Closed)

Created:
7 years, 2 months ago by arv (Not doing code reviews)

Modified:
7 years, 2 months ago

Reviewers:
do-not-use, abarth-chromium

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Setting host without port should keep old port This makes us compatible with Firefox, IE and the spec: http://url.spec.whatwg.org/#dom-url-host BUG=304946 R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159239

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
M	LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js	View		3 chunks	+11 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLAnchorElement.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

arv (Not doing code reviews)

This depends on https://codereview.chromium.org/26248003/

7 years, 2 months ago (2013-10-08 16:27:37 UTC) #1

abarth-chromium

LGTM if this improve spec compliance and/or compatibility with other user agents. Please add information ...

7 years, 2 months ago (2013-10-09 15:04:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/26506003/9001

7 years, 2 months ago (2013-10-09 15:13:22 UTC) #4

Message was sent while issue was closed.

Change committed as 159239