Added tracking of memory usage within ApiNativeScopes. Usage to be displayed within Observatory.

Added tracking of memory usage within ApiNativeScopes. Usage to be displayed within Observatory.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/1e0bf05aafbbbc595df83068439eb11debf3eeca

[bkonyi, 2017-01-25 22:59:40]

bkonyi@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com, zra@google.com

[bkonyi, 2017-01-25 22:59:40]

This change adds the code to actually track the current memory usage of
ApiNativeScopes. This value will be shown somewhere in the observatory once we
figure out the best place to display it.

[siva, 2017-01-26 03:02:05]

Where is the code that adds it to the response of the service request for memory
usage.

https://codereview.chromium.org/2650583014/diff/1/runtime/vm/zone.cc
File runtime/vm/zone.cc (right):

https://codereview.chromium.org/2650583014/diff/1/runtime/vm/zone.cc#newcode52
runtime/vm/zone.cc:52: // If there is no current thread, we might be iniside of
a native scope.
iniside => inside

[bkonyi, 2017-01-26 17:43:59]

On 2017/01/26 03:02:05, siva wrote:
> Where is the code that adds it to the response of the service request for
memory
> usage.
> 
> https://codereview.chromium.org/2650583014/diff/1/runtime/vm/zone.cc
> File runtime/vm/zone.cc (right):
> 
> https://codereview.chromium.org/2650583014/diff/1/runtime/vm/zone.cc#newcode52
> runtime/vm/zone.cc:52: // If there is no current thread, we might be iniside
of
> a native scope.
> iniside => inside

I was going to add that in another CL, but I can add it in this one if you'd
prefer.

[bkonyi, 2017-01-26 22:34:27]

https://codereview.chromium.org/2650583014/diff/1/runtime/vm/zone.cc
File runtime/vm/zone.cc (right):

https://codereview.chromium.org/2650583014/diff/1/runtime/vm/zone.cc#newcode52
runtime/vm/zone.cc:52: // If there is no current thread, we might be iniside of
a native scope.
On 2017/01/26 03:02:05, siva wrote:
> iniside => inside

Done.

https://codereview.chromium.org/2650583014/diff/20001/runtime/vm/zone.cc
File runtime/vm/zone.cc (right):

https://codereview.chromium.org/2650583014/diff/20001/runtime/vm/zone.cc#newc...
runtime/vm/zone.cc:91: // watermarks or memory consumption.
I'm going to address this in a future change. Should only result in thread
memory consumption calculations being off by 1KB per active zone at the moment.

[siva, 2017-01-26 23:19:47]

lgtm

[bkonyi, 2017-01-26 23:24:11]

Description was changed from

==========
Added tracking of memory usage within ApiNativeScopes. Usage to be displayed
within Observatory.

BUG=
==========

to

==========
Added tracking of memory usage within ApiNativeScopes. Usage to be displayed
within Observatory.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1e0bf05aafbbbc595df83068439eb11debf3eeca
==========

[bkonyi, 2017-01-26 23:24:12]

Committed patchset #2 (id:20001) manually as
1e0bf05aafbbbc595df83068439eb11debf3eeca (presubmit successful).