Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2650583005: Revert "Make HTTP headers use a growing buffer, not a fixed-size 8K one." (Closed)

Created:
3 years, 11 months ago by keertip
Modified:
3 years, 11 months ago
Reviewers:
Bill Hesse, dgrove, srawlins
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, dgrove
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make HTTP headers use a growing buffer, not a fixed-size 8K one." This reverts commit 51197954224cc98439670f08e0b5553c643b4e96. BUG= R=dgrove@google.com Committed: https://github.com/dart-lang/sdk/commit/1d6bd5255d14ed822eb0f2e58a7b2013309e9c23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -100 lines) Patch
M sdk/lib/io/bytes_builder.dart View 5 chunks +20 lines, -45 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 1 chunk +24 lines, -14 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 7 chunks +70 lines, -41 lines 0 comments Download
M tests/standalone/io/http_client_request_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
keertip
3 years, 11 months ago (2017-01-23 22:18:14 UTC) #2
keertip
3 years, 11 months ago (2017-01-23 22:18:29 UTC) #3
dgrove
lgtm
3 years, 11 months ago (2017-01-23 22:55:32 UTC) #7
keertip
3 years, 11 months ago (2017-01-23 22:57:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d6bd5255d14ed822eb0f2e58a7b2013309e9c23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698